change: Add PipelineVariable annotation in amazon models #3187

qidewenwhen · 2022-06-21T18:15:28Z

Description of changes: This PR adds PipelineVariable annotation in amazon models. The PipelineVariable annotation will be leveraged by a test mechanism: #3163 to scan and check the incompatible issues between Pipeline steps and downstream classes caused by pipeline variables.

Testing done: unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-06-21T18:45:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9aefc20
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T18:50:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9aefc20
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T19:04:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9aefc20
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-06-21T19:04:58Z

Codecov Report

Merging #3187 (127fe57) into master (b4f05b8) will increase coverage by 0.02%.
The diff coverage is 98.64%.

❗ Current head 127fe57 differs from pull request most recent head 513f83c. Consider uploading reports for the commit 513f83c to get more accurate results

@@            Coverage Diff             @@
##           master    #3187      +/-   ##
==========================================
+ Coverage   88.79%   88.81%   +0.02%     
==========================================
  Files         203      202       -1     
  Lines       17978    17886      -92     
==========================================
- Hits        15963    15886      -77     
+ Misses       2015     2000      -15

Impacted Files	Coverage Δ
src/sagemaker/utils.py	`92.06% <88.88%> (-0.63%)`	⬇️
src/sagemaker/amazon/factorization_machines.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/ipinsights.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/kmeans.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/knn.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/lda.py	`97.87% <100.00%> (+0.25%)`	⬆️
src/sagemaker/amazon/linear_learner.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/ntm.py	`100.00% <100.00%> (ø)`
src/sagemaker/amazon/object2vec.py	`99.05% <100.00%> (+0.04%)`	⬆️
src/sagemaker/amazon/pca.py	`100.00% <100.00%> (ø)`
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f05b8...513f83c. Read the comment docs.

sagemaker-bot · 2022-06-21T19:16:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9aefc20
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T19:27:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9aefc20
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T21:19:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e0e92b7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T21:41:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e0e92b7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T21:56:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e0e92b7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T22:19:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e0e92b7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T22:20:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e0e92b7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-22T00:57:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: bad887a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-22T01:20:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bad887a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-22T01:38:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bad887a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-22T01:48:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: bad887a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-22T02:01:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bad887a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-29T02:25:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 127fe57
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-29T02:30:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 127fe57
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-29T02:46:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 127fe57
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-29T03:07:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 127fe57
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-29T03:29:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 127fe57
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T03:41:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6ae27f8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T03:53:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6ae27f8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T04:01:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6ae27f8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T04:21:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6ae27f8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T04:23:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6ae27f8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-23T02:39:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 513f83c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-23T02:54:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 513f83c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-23T02:57:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 513f83c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-23T03:14:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 513f83c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-23T03:22:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 513f83c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T18:38:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 22fd18c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T18:59:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 22fd18c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T19:05:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 22fd18c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T19:18:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 22fd18c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-27T19:22:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 22fd18c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Dewen Qi <[email protected]>

qidewenwhen force-pushed the am_model_anno branch from 9aefc20 to e0e92b7 Compare June 21, 2022 21:13

qidewenwhen force-pushed the am_model_anno branch from e0e92b7 to bad887a Compare June 22, 2022 00:51

qidewenwhen force-pushed the am_model_anno branch from bad887a to 127fe57 Compare June 29, 2022 02:19

qidewenwhen force-pushed the am_model_anno branch from 127fe57 to 6ae27f8 Compare July 8, 2022 03:13

navaj0 approved these changes Jul 13, 2022

View reviewed changes

qidewenwhen force-pushed the am_model_anno branch from 6ae27f8 to 513f83c Compare July 23, 2022 02:10

mufaddal-rohawala requested a review from shreyapandit July 27, 2022 05:11

shreyapandit approved these changes Jul 27, 2022

View reviewed changes

change: Add PipelineVariable annotation in amazon models

22fd18c

qidewenwhen force-pushed the am_model_anno branch from 513f83c to 22fd18c Compare July 27, 2022 18:10

mufaddal-rohawala merged commit 87d7182 into aws:master Jul 27, 2022

knikure pushed a commit to knikure/sagemaker-python-sdk that referenced this pull request Aug 4, 2022

change: Add PipelineVariable annotation in amazon models (aws#3187)

67ff491

Co-authored-by: Dewen Qi <[email protected]>

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

change: Add PipelineVariable annotation in amazon models (aws#3187)

9b306b9

Co-authored-by: Dewen Qi <[email protected]>

qidewenwhen deleted the am_model_anno branch January 25, 2024 18:34

change: Add PipelineVariable annotation in amazon models #3187

change: Add PipelineVariable annotation in amazon models #3187

Conversation

qidewenwhen commented Jun 21, 2022 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

codecov-commenter commented Jun 21, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 22, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 29, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 23, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 27, 2022

AWS CodeBuild CI Report

qidewenwhen commented Jun 21, 2022 •

edited

Loading

codecov-commenter commented Jun 21, 2022 •

edited

Loading