fix: fix: neo inferentia as compilation target not using framework ver #3183

HappyAmazonian · 2022-06-20T21:01:12Z

…sion

Issue #, if available:

Description of changes: For inferentia as compilation target device, we need to add Framework Version in the create_compilation_job requests to get the best result.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-06-20T22:13:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4820aa9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-20T22:31:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4820aa9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-20T22:46:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4820aa9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-20T22:58:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2815038
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-20T23:22:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2815038
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-06-20T23:22:29Z

Codecov Report

Merging #3183 (61f331b) into master (e21b457) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3183   +/-   ##
=======================================
  Coverage   88.80%   88.81%           
=======================================
  Files         202      202           
  Lines       17853    17861    +8     
=======================================
+ Hits        15855    15863    +8     
  Misses       1998     1998

Impacted Files	Coverage Δ
src/sagemaker/model.py	`92.77% <100.00%> (+0.17%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21b457...61f331b. Read the comment docs.

sagemaker-bot · 2022-06-20T23:23:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4820aa9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-20T23:30:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2815038
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-20T23:31:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4820aa9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-20T23:37:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2815038
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-20T23:42:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0a053a9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T00:01:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0a053a9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T00:02:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2815038
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T00:10:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0a053a9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T00:22:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0a053a9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-21T00:42:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0a053a9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-27T17:44:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: cc3dad8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-27T18:21:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cc3dad8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-27T18:24:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: cc3dad8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-27T18:25:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: cc3dad8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-06-27T18:48:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: cc3dad8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T18:58:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ed1b9ed
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T19:07:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ed1b9ed
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T19:16:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ed1b9ed
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T19:20:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ed1b9ed
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-06T19:39:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ed1b9ed
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni · 2022-07-06T20:32:02Z

src/sagemaker/model.py

+                if re.match("(?=^ml_)", target_instance_type):
+                    return framework in multi_version_frameworks_support_mapping["ml_ioc"]


what are the options for instance type. do they have ml_ioc.

ioc target means: ml_c4, ml_c5, ml_m4, ml_m5, ml_p2, ml_p3, ml_g4dn, they support torch and tf framework_versions.
ml_inf1 supports torch, tf and mxnet.

I can make it more explicit if you think it is better. (I was trying to make the change minimal)

do you want to select ioc first and then inf

sagemaker-bot · 2022-07-07T00:35:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 890984d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-07T00:55:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 890984d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-07T01:05:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 890984d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-07T01:19:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 890984d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-07T01:34:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 890984d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/model.py

lekk32

I recall there was another bug for edge targets not getting framework version, thats not being handled here right?

…sion

sagemaker-bot · 2022-07-08T00:03:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 61f331b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T00:10:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 61f331b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T00:19:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 61f331b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T00:22:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 61f331b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-07-08T00:42:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 61f331b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws#3183)

HappyAmazonian force-pushed the ml-inf-multi-version branch from 4820aa9 to 2815038 Compare June 20, 2022 22:49

navinsoni reviewed Jul 6, 2022

View reviewed changes

HappyAmazonian force-pushed the ml-inf-multi-version branch from ed1b9ed to 890984d Compare July 7, 2022 00:29

navinsoni approved these changes Jul 7, 2022

View reviewed changes

lekk32 reviewed Jul 7, 2022

View reviewed changes

src/sagemaker/model.py Show resolved Hide resolved

lekk32 approved these changes Jul 7, 2022

View reviewed changes

fix: fix neo inferentia as compilation target not using framework ver…

61f331b

…sion

HappyAmazonian force-pushed the ml-inf-multi-version branch from 890984d to 61f331b Compare July 7, 2022 23:35

navinsoni requested a review from mufaddal-rohawala July 8, 2022 22:34

mufaddal-rohawala approved these changes Jul 8, 2022

View reviewed changes

mufaddal-rohawala changed the title ~~fix: fix neo inferentia as compilation target not using framework ver…~~ fix: fix: neo inferentia as compilation target not using framework ver Jul 8, 2022

mufaddal-rohawala merged commit e5f58f3 into aws:master Jul 8, 2022

HappyAmazonian deleted the ml-inf-multi-version branch July 28, 2022 19:00

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request Aug 8, 2022

fix: fix: neo inferentia as compilation target not using framework ver (

a739439

aws#3183)

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

fix: fix: neo inferentia as compilation target not using framework ver (

24bbbdf

aws#3183)

		if re.match("(?=^ml_)", target_instance_type):
		return framework in multi_version_frameworks_support_mapping["ml_ioc"]

fix: fix: neo inferentia as compilation target not using framework ver #3183

fix: fix: neo inferentia as compilation target not using framework ver #3183

Conversation

HappyAmazonian commented Jun 20, 2022 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Jun 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 20, 2022

AWS CodeBuild CI Report

codecov-commenter commented Jun 20, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Jun 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 20, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 21, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jun 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 6, 2022

AWS CodeBuild CI Report

navinsoni Jul 6, 2022

Choose a reason for hiding this comment

HappyAmazonian Jul 6, 2022

Choose a reason for hiding this comment

navinsoni Jul 6, 2022

Choose a reason for hiding this comment

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2022

AWS CodeBuild CI Report

lekk32 left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jul 8, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jul 8, 2022

HappyAmazonian commented Jun 20, 2022 •

edited

Loading

codecov-commenter commented Jun 20, 2022 •

edited

Loading