-
Notifications
You must be signed in to change notification settings - Fork 1.2k
add new sklearn release 1.0-1 #3125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## master #3125 +/- ##
=======================================
Coverage 89.61% 89.62%
=======================================
Files 200 200
Lines 17356 17356
=======================================
+ Hits 15554 15555 +1
+ Misses 1802 1801 -1
Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@secastillo can you help? Without this change, the new image is not easily usable for many users. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thanks @secastillo to pick this up in #3110. A ping for this PR or a reference to the issue would have been nice to keep track of this. Found out it was solved in #3110 by chance. Also, don't you think we should also update the tests to use |
@lorenzwalthert is this issue resolved for you. If yes can you please close this PR. |
I am not familiar enough with this package but one difference between this PR and #3110 is that here I also adapt the tests. But it has accumulated merge conflicts so let’s just close it and trust you have Integration tests elsewhere. |
Issue #, if available:
#3061
Description of changes:
Add support for new scikit learn framework version. There were two previously supported versions:
I have replaced all instances of the version 0.23-1 with 1.0-1 in python source files. Documentation examples were also adapted where appropriate, some of them alos had 0.20.0. However, there were still some (integration) tests, documentation and CLI functionality that used the 0.20.0 version. Please advise what to do there, I currenlty left these unchanged.
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.