Skip to content

fix: fix missing register method params for framework models #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2022
Merged

fix: fix missing register method params for framework models #3122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38b9114
fix: fix missing register method params for framework models
bobbywlindsey May 20, 2022
494e0d9
Merge branch 'master' into missing-register-params
bobbywlindsey May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/sagemaker/huggingface/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ def register(
approval_status=None,
description=None,
drift_check_baselines=None,
customer_metadata_properties=None,
domain=None,
):
"""Creates a model package for creating SageMaker models or listing on Marketplace.
Expand Down Expand Up @@ -332,6 +333,8 @@ def register(
or "PendingManualApproval". Defaults to ``PendingManualApproval``.
description (str): Model Package description. Defaults to ``None``.
drift_check_baselines (DriftCheckBaselines): DriftCheckBaselines object (default: None).
customer_metadata_properties (dict[str, str]): A dictionary of key-value paired
metadata properties (default: None).
domain (str): Domain values can be "COMPUTER_VISION", "NATURAL_LANGUAGE_PROCESSING",
"MACHINE_LEARNING" (default: None).

Expand Down Expand Up @@ -362,6 +365,7 @@ def register(
approval_status,
description,
drift_check_baselines=drift_check_baselines,
customer_metadata_properties=customer_metadata_properties,
domain=domain,
)

Expand Down
7 changes: 7 additions & 0 deletions src/sagemaker/sklearn/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ def register(
marketplace_cert=False,
approval_status=None,
description=None,
drift_check_baselines=None,
customer_metadata_properties=None,
domain=None,
):
"""Creates a model package for creating SageMaker models or listing on Marketplace.
Expand All @@ -176,6 +178,9 @@ def register(
approval_status (str): Model Approval Status, values can be "Approved", "Rejected",
or "PendingManualApproval" (default: "PendingManualApproval").
description (str): Model Package description (default: None).
drift_check_baselines (DriftCheckBaselines): DriftCheckBaselines object (default: None).
customer_metadata_properties (dict[str, str]): A dictionary of key-value paired
metadata properties (default: None).
domain (str): Domain values can be "COMPUTER_VISION", "NATURAL_LANGUAGE_PROCESSING",
"MACHINE_LEARNING" (default: None).

Expand Down Expand Up @@ -205,6 +210,8 @@ def register(
marketplace_cert,
approval_status,
description,
drift_check_baselines=drift_check_baselines,
customer_metadata_properties=customer_metadata_properties,
domain=domain,
)

Expand Down