change: turn off Pipeline Parameter inheritance from python primitives #3086

qidewenwhen · 2022-04-27T23:59:45Z

Issues: #3091

Description of changes:

Turn off Pipeline Parameter inheritance from python primitives as this has brought many hidden problems
Clean up PipelineNonPrimitiveInputTypes type collection as it's duplicate with PipelineVariable
Change the behavior of startswith and endswith of PipelineVariable. Instead of always return false, we should throw exceptions explicitly here as the return false can hide some problems.

Testing done: unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-04-28T00:03:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3a91c44
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-28T00:17:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 70285f6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-04-28T00:18:01Z

Codecov Report

Merging #3086 (c3e777b) into master (d61dec6) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3086      +/-   ##
==========================================
- Coverage   89.69%   89.60%   -0.09%     
==========================================
  Files        1048      200     -848     
  Lines       87656    17342   -70314     
==========================================
- Hits        78622    15540   -63082     
+ Misses       9034     1802    -7232

Impacted Files	Coverage Δ
src/sagemaker/estimator.py	`90.88% <ø> (ø)`
src/sagemaker/workflow/fail_step.py	`100.00% <ø> (ø)`
src/sagemaker/fw_utils.py	`90.42% <100.00%> (+0.20%)`	⬆️
src/sagemaker/workflow/clarify_check_step.py	`97.50% <100.00%> (ø)`
src/sagemaker/workflow/entities.py	`97.22% <100.00%> (-0.28%)`	⬇️
src/sagemaker/workflow/parameters.py	`98.21% <100.00%> (-0.40%)`	⬇️
src/sagemaker/workflow/quality_check_step.py	`100.00% <100.00%> (ø)`
src/sagemaker/workflow/steps.py	`96.56% <100.00%> (+0.03%)`	⬆️
src/sagemaker/processing.py	`95.55% <0.00%> (-0.28%)`	⬇️
...es/sagemaker/cli/compatibility/v2/modifiers/tfs.py
... and 848 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d61dec6...c3e777b. Read the comment docs.