Use existing model instead of failing during Session.create_model() #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
=========================================
- Coverage 93.05% 92.8% -0.25%
=========================================
Files 50 50
Lines 3456 3463 +7
=========================================
- Hits 3216 3214 -2
- Misses 240 249 +9
Continue to review full report at Codecov.
|
nadiaya
approved these changes
Jul 19, 2018
| PrimaryContainer=primary_container, | ||
| ExecutionRoleArn=role) | ||
| try: | ||
| self.sagemaker_client.create_model(ModelName=name, |
There was a problem hiding this comment.
Talked offline about checking whether model exist first.
Agreed to leave it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently an exception is raised if a model already exists. This change instead logs a warning that an existing model is being used, but allows the existing model to be used in place of needing to create a new one.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.