Skip to content

#using uuid to randomize, otherwise system timestamp is used #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 13, 2022
Merged

#using uuid to randomize, otherwise system timestamp is used #3046

merged 3 commits into from
Apr 13, 2022

Conversation

sermolin
Copy link
Contributor

@sermolin sermolin commented Apr 4, 2022 •
edited
Loading

Issue #, if available:
Customer reported issue when load-testing multiple notebooks:

"While executing AutoGluon Notebook, 5/20 users encountered failures while creating a model and endpoint. We modified our examples to create a unique resource name using sagemaker util below. Looks like, collision seems high with this tool.
model_name = sagemaker.utils.unique_name_from_base("inf-pipeline-model")
As the seed for random by default is timestamp it is creating same unique 4-digit hex when accessed around same time"

Description of changes:
#using uuid to randomize random.seed(), otherwise system timestamp is used.

Testing done:
Modified sagemaker sdk locally, tested changes.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x ] I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 34a99e2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 34a99e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 34a99e2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sermolin
Copy link
Contributor Author

sermolin commented Apr 5, 2022

[fixed comment line by running -m tox -e black-format], changed wording to comply

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 0dc3088
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 0dc3088
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sermolin
Copy link
Contributor Author

sermolin commented Apr 6, 2022

moved "import uuid" above "import botocore" to fix CI error message

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #3046 (35eb5f3) into master (6fb0a99) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3046   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files         197      197           
  Lines       16668    16670    +2     
=======================================
+ Hits        14898    14900    +2     
  Misses       1770     1770
Impacted Files Coverage Δ
src/sagemaker/utils.py 92.56% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb0a99...35eb5f3. Read the comment docs.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f14d475
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: f14d475
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: f14d475
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@BasilBeirouti BasilBeirouti force-pushed the unique_name_from_base_randomize_uuid branch from f14d475 to 35eb5f3 Compare April 13, 2022 22:00
@BasilBeirouti BasilBeirouti self-requested a review April 13, 2022 22:04
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 35eb5f3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@BasilBeirouti BasilBeirouti merged commit c424bce into aws:master Apr 13, 2022
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 35eb5f3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022
@jerrypeng7773
#using uuid to randomize, otherwise system timestamp is used (aws#3046)
d7a942d 
* #using uuid to randomize, otherwise system timestamp is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BasilBeirouti BasilBeirouti BasilBeirouti approved these changes

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sermolin @sagemaker-bot @codecov-commenter @BasilBeirouti @mufaddal-rohawala