Skip to content

fix: temporarily skip tests impacted by data inconsistency #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import os
from glob import glob

from setuptools import setup, find_packages
from setuptools import find_packages, setup


def read(fname):
Expand Down Expand Up @@ -81,6 +81,7 @@ def read_version():
"fabric==2.6.0",
"requests==2.27.1",
"sagemaker-experiments==0.1.35",
"Jinja2==3.0.3",
],
)

Expand Down
7 changes: 4 additions & 3 deletions tests/integ/sagemaker/lineage/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -709,9 +709,10 @@ def static_model_artifact(sagemaker_session, static_pipeline_execution_arn):
)
)

yield artifact.ModelArtifact.load(
artifacts[0]["ArtifactArn"], sagemaker_session=sagemaker_session
)
artifact_arn = artifacts[0]["ArtifactArn"]
logging.info(f"Using static model artifact {artifact_arn}")

yield artifact.ModelArtifact.load(artifact_arn, sagemaker_session=sagemaker_session)


@pytest.fixture
Expand Down
4 changes: 4 additions & 0 deletions tests/integ/sagemaker/lineage/test_action.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ def test_tags(action_obj, sagemaker_session):
assert [actual_tags[-1]] == tags


@pytest.mark.skip("data inconsistency P61661075")
def test_upstream_artifacts(static_model_deployment_action):
artifacts_from_query = static_model_deployment_action.artifacts(
direction=LineageQueryDirectionEnum.ASCENDANTS
Expand All @@ -129,6 +130,7 @@ def test_upstream_artifacts(static_model_deployment_action):
assert "artifact" in artifact.artifact_arn


@pytest.mark.skip("data inconsistency P61661075")
def test_downstream_artifacts(static_approval_action):
artifacts_from_query = static_approval_action.artifacts(
direction=LineageQueryDirectionEnum.DESCENDANTS
Expand All @@ -138,6 +140,7 @@ def test_downstream_artifacts(static_approval_action):
assert "artifact" in artifact.artifact_arn


@pytest.mark.skip("data inconsistency P61661075")
def test_datasets(static_approval_action, static_dataset_artifact, sagemaker_session):
try:
sagemaker_session.sagemaker_client.add_association(
Expand Down Expand Up @@ -165,6 +168,7 @@ def test_datasets(static_approval_action, static_dataset_artifact, sagemaker_ses
pass


@pytest.mark.skip("data inconsistency P61661075")
def test_endpoints(static_approval_action):
endpoint_contexts_from_query = static_approval_action.endpoints()
assert len(endpoint_contexts_from_query) > 0
Expand Down
1 change: 1 addition & 0 deletions tests/integ/sagemaker/lineage/test_artifact.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ def test_list_by_type(artifact_objs, sagemaker_session):
assert artifact_names_listed[0] == expected_name


@pytest.mark.skip("data inconsistency P61661075")
def test_get_artifact(static_dataset_artifact):
s3_uri = static_dataset_artifact.source.source_uri
expected_artifact = static_dataset_artifact.s3_uri_artifacts(s3_uri=s3_uri)
Expand Down
5 changes: 5 additions & 0 deletions tests/integ/sagemaker/lineage/test_dataset_artifact.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
"""This module contains code to test SageMaker ``DatasetArtifact``"""
from __future__ import absolute_import

import pytest


def test_trained_models(
dataset_artifact_associated_models,
Expand All @@ -27,6 +29,7 @@ def test_trained_models(
assert model.destination_type == "Context"


@pytest.mark.skip("data inconsistency P61661075")
def test_endpoint_contexts(
static_dataset_artifact,
):
Expand All @@ -37,6 +40,7 @@ def test_endpoint_contexts(
assert context.context_type == "Endpoint"


@pytest.mark.skip("data inconsistency P61661075")
def test_get_upstream_datasets(static_dataset_artifact, sagemaker_session):
artifacts_from_query = static_dataset_artifact.upstream_datasets()
assert len(artifacts_from_query) > 0
Expand All @@ -45,6 +49,7 @@ def test_get_upstream_datasets(static_dataset_artifact, sagemaker_session):
assert "artifact" in artifact.artifact_arn


@pytest.mark.skip("data inconsistency P61661075")
def test_get_down_datasets(static_dataset_artifact, sagemaker_session):
artifacts_from_query = static_dataset_artifact.downstream_datasets()
assert len(artifacts_from_query) > 0
Expand Down
8 changes: 8 additions & 0 deletions tests/integ/sagemaker/lineage/test_endpoint_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
from __future__ import absolute_import
import time

import pytest

SLEEP_TIME_ONE_SECONDS = 1
SLEEP_TIME_THREE_SECONDS = 3

Expand All @@ -38,6 +40,7 @@ def test_model_v2(endpoint_context_associate_with_model, model_obj, sagemaker_se
assert model.properties == model_obj.properties


@pytest.mark.skip("data inconsistency P61661075")
def test_dataset_artifacts(static_endpoint_context):
artifacts_from_query = static_endpoint_context.dataset_artifacts()

Expand All @@ -46,6 +49,7 @@ def test_dataset_artifacts(static_endpoint_context):
assert artifact.artifact_type == "DataSet"


@pytest.mark.skip("data inconsistency P61661075")
def test_training_job_arns(
static_endpoint_context,
):
Expand All @@ -56,12 +60,14 @@ def test_training_job_arns(
assert "training-job" in arn


@pytest.mark.skip("data inconsistency P61661075")
def test_pipeline_execution_arn(static_endpoint_context, static_pipeline_execution_arn):
pipeline_execution_arn = static_endpoint_context.pipeline_execution_arn()

assert pipeline_execution_arn == static_pipeline_execution_arn


@pytest.mark.skip("data inconsistency P61661075")
def test_transform_jobs(
sagemaker_session, static_transform_job_trial_component, static_endpoint_context
):
Expand All @@ -84,6 +90,7 @@ def test_transform_jobs(
)


@pytest.mark.skip("data inconsistency P61661075")
def test_processing_jobs(
sagemaker_session, static_transform_job_trial_component, static_endpoint_context
):
Expand All @@ -94,6 +101,7 @@ def test_processing_jobs(
assert "ProcessingJob" in processing_job.source.get("SourceType")


@pytest.mark.skip("data inconsistency P61661075")
def test_trial_components(
sagemaker_session, static_transform_job_trial_component, static_endpoint_context
):
Expand Down
3 changes: 3 additions & 0 deletions tests/integ/sagemaker/lineage/test_image_artifact.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,12 @@
"""This module contains code to test SageMaker ``ImageArtifact``"""
from __future__ import absolute_import

import pytest

from sagemaker.lineage.query import LineageQueryDirectionEnum


@pytest.mark.skip("data inconsistency P61661075")
def test_dataset(static_image_artifact, sagemaker_session):
artifacts_from_query = static_image_artifact.datasets(
direction=LineageQueryDirectionEnum.DESCENDANTS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,26 @@
"""This module contains code to test SageMaker ``Trial Component``"""
from __future__ import absolute_import

import pytest


@pytest.mark.skip("data inconsistency P61661075")
def test_dataset_artifacts(static_training_job_trial_component):
artifacts_from_query = static_training_job_trial_component.dataset_artifacts()
assert len(artifacts_from_query) > 0
for artifact in artifacts_from_query:
assert artifact.artifact_type == "DataSet"


@pytest.mark.skip("data inconsistency P61661075")
def test_models(static_processing_job_trial_component):
artifacts_from_query = static_processing_job_trial_component.models()
assert len(artifacts_from_query) > 0
for artifact in artifacts_from_query:
assert artifact.artifact_type == "Model"


@pytest.mark.skip("data inconsistency P61661075")
def test_pipeline_execution_arn(static_training_job_trial_component, static_pipeline_execution_arn):
pipeline_execution_arn = static_training_job_trial_component.pipeline_execution_arn()
assert pipeline_execution_arn == static_pipeline_execution_arn
5 changes: 5 additions & 0 deletions tests/integ/sagemaker/lineage/test_model_artifact.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
"""This module contains code to test SageMaker ``DatasetArtifact``"""
from __future__ import absolute_import

import pytest


def test_endpoints(
model_artifact_associated_endpoints,
Expand All @@ -38,6 +40,7 @@ def test_endpoint_contexts(
assert context.context_type == "Endpoint"


@pytest.mark.skip("data inconsistency P61661075")
def test_dataset_artifacts(
static_model_artifact,
):
Expand All @@ -48,6 +51,7 @@ def test_dataset_artifacts(
assert artifact.artifact_type == "DataSet"


@pytest.mark.skip("data inconsistency P61661075")
def test_training_job_arns(
static_model_artifact,
):
Expand All @@ -58,6 +62,7 @@ def test_training_job_arns(
assert "training-job" in arn


@pytest.mark.skip("data inconsistency P61661075")
def test_pipeline_execution_arn(static_model_artifact, static_pipeline_execution_arn):
pipeline_execution_arn = static_model_artifact.pipeline_execution_arn()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
"""This module contains code to test SageMaker ``ModelPackageGroup``"""
from __future__ import absolute_import

import pytest


@pytest.mark.skip("data inconsistency P61661075")
def test_pipeline_execution_arn(static_model_package_group_context, static_pipeline_execution_arn):
pipeline_execution_arn = static_model_package_group_context.pipeline_execution_arn()

Expand Down