Skip to content

Deleting endpoint for PyTorch test, retrying endpoint deletion 3 times #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 26, 2018

Conversation

mvsusp
Copy link
Contributor

@mvsusp mvsusp commented Jul 17, 2018

Issue #, if available:

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mvsusp mvsusp requested review from nadiaya and laurenyu July 17, 2018 00:00
nadiaya
nadiaya previously approved these changes Jul 17, 2018
if ce.response['Error']['Code'] == 'ValidationException':
# avoids the inner exception to be overwritten
pass
# trying to delte the resource again in 10 seconds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo 'delete'

@codecov-io
Copy link

codecov-io commented Jul 17, 2018

Codecov Report

Merging #297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files          50       50           
  Lines        3472     3472           
=======================================
  Hits         3227     3227           
  Misses        245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e5577f...d47aafe. Read the comment docs.

nadiaya
nadiaya previously approved these changes Jul 17, 2018
@yangaws yangaws merged commit eb5099c into aws:master Jul 26, 2018
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
knakad added a commit to knakad/sagemaker-python-sdk that referenced this pull request Dec 4, 2019
knakad added a commit that referenced this pull request Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants