Bug fix: https://github.com/aws/sagemaker-python-sdk/issues/123 #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andremoeller
suggested changes
Jul 16, 2018
setup.py
Outdated
| @@ -49,7 +49,7 @@ def read(fname): | |||
|
|
|||
| extras_require={ | |||
| 'test': ['tox', 'flake8', 'pytest', 'pytest-cov', 'pytest-xdist', | |||
| 'mock', 'tensorflow>=1.3.0', 'contextlib2', 'awslogs', 'pandas']}, | |||
| 'mock', 'tensorflow>=1.3.0', 'protobuf3-to-dict', 'contextlib2', 'awslogs', 'pandas']}, | |||
There was a problem hiding this comment.
Could you move protobuf3-to-dict to install_requires (and add a version)?
|
|
||
| for possible_response in _POSSIBLE_RESPONSES: | ||
| try: | ||
| return protobuf_to_dict(json_format.Parse(data, possible_response())) |
There was a problem hiding this comment.
Would google.protobuf.json_format.MessageToDict (with json.loads) be suitable here?
There was a problem hiding this comment.
I actually tried and won't work. google.protobuf.json_format.MessageToDict serializes the values again, which is the bug behavior that we won't to avoid.
andremoeller
previously approved these changes
Jul 17, 2018
andremoeller
previously approved these changes
Jul 20, 2018
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
==========================================
- Coverage 92.94% 92.92% -0.03%
==========================================
Files 50 50
Lines 3472 3475 +3
==========================================
+ Hits 3227 3229 +2
- Misses 245 246 +1
Continue to review full report at Codecov.
|
andremoeller
approved these changes
Jul 26, 2018
knakad
added a commit
to knakad/sagemaker-python-sdk
that referenced
this pull request
Dec 4, 2019
knakad
added a commit
that referenced
this pull request
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Bug fix for #123
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.