fix: EstimatorTransformer entry point error #2905

eugeneteoh · 2022-02-06T21:16:21Z

Issue #, if available:

Description of changes:
EstimatorTransformer currently does not work when entry_point argument is provided. Additionally, EstimatorTransformer contains a required argument estimator, where it is only used to identify sagemaker_session, role, subnets and security_group_ids. The docstrings are also not updated.

The proposed change is to:

Ensure EstimatorTransformer works with entry_point argument.
Remove estimator and add sagemaker_session and role as arguments.
Update EstimatorTransformer docstrings.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter · 2022-02-06T21:30:06Z

Codecov Report

Merging #2905 (a8966ec) into dev (9d612a7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #2905      +/-   ##
==========================================
+ Coverage   89.49%   89.53%   +0.03%     
==========================================
  Files         195      195              
  Lines       16567    16572       +5     
==========================================
+ Hits        14826    14837      +11     
+ Misses       1741     1735       -6

Impacted Files	Coverage Δ
src/sagemaker/inputs.py	`100.00% <ø> (ø)`
src/sagemaker/model.py	`91.41% <ø> (ø)`
src/sagemaker/session.py	`70.57% <ø> (ø)`
src/sagemaker/workflow/step_collections.py	`98.98% <100.00%> (+6.43%)`	⬆️
src/sagemaker/workflow/steps.py	`97.34% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea4b80...a8966ec. Read the comment docs.

sagemaker-bot · 2022-02-06T21:38:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c49533a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-06T22:33:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c49533a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-06T22:51:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c49533a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T21:40:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6317caa
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T22:08:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ba40cb7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T22:25:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b44f0bb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T22:30:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6317caa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T22:46:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6317caa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T22:59:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b44f0bb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T22:59:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ba40cb7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T23:14:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b44f0bb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T23:14:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6317caa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T23:34:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ba40cb7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-07T23:34:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b44f0bb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-08T12:19:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8eb2153
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-08T13:11:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8eb2153
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-08T13:51:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8eb2153
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-08T14:19:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a8966ec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-08T15:11:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a8966ec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-08T15:51:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a8966ec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eugeneteoh · 2022-02-08T21:59:50Z

Closing this PR as most of these changes are included in #2804.

jeniyat force-pushed the dev branch from 9d612a7 to bb7563f Compare February 7, 2022 23:40

Eugene Teoh added 4 commits February 8, 2022 11:54

fix: fix EstimatorTransformer entry point error

d05cc8a

fix: test_estimator_transformer

9e460f2

fix: add estimator transformer with model repack test

af84f59

fix: format with black

8eb2153

eugeneteoh force-pushed the fix-estimatortransformer branch from b44f0bb to 8eb2153 Compare February 8, 2022 11:55

fix: update docstrings

a8966ec

eugeneteoh marked this pull request as ready for review February 8, 2022 13:57

eugeneteoh closed this Feb 8, 2022

fix: EstimatorTransformer entry point error #2905

fix: EstimatorTransformer entry point error #2905

Uh oh!

Conversation

eugeneteoh commented Feb 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

codecov-commenter commented Feb 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Feb 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 6, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 7, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 8, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 8, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 8, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 8, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 8, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 8, 2022

AWS CodeBuild CI Report

Uh oh!

eugeneteoh commented Feb 8, 2022

Uh oh!

Uh oh!

eugeneteoh commented Feb 6, 2022 •

edited

Loading

codecov-commenter commented Feb 6, 2022 •

edited

Loading