Skip to content

Mark pytorch and chainer tests to be used for continuous testing. #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

nadiaya
Copy link
Contributor

@nadiaya nadiaya commented Jul 12, 2018

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nadiaya nadiaya requested review from laurenyu and yangaws July 12, 2018 18:23
Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/integration/testing in the commit message - these aren't used as part of a build system

@nadiaya nadiaya changed the title Mark pytorch and chainer tests to be used for continuous integration. Mark pytorch and chainer tests to be used for continuous testing. Jul 12, 2018
@codecov-io
Copy link

codecov-io commented Jul 12, 2018

Codecov Report

Merging #290 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   92.42%   92.48%   +0.06%     
==========================================
  Files          49       49              
  Lines        3313     3313              
==========================================
+ Hits         3062     3064       +2     
+ Misses        251      249       -2
Impacted Files Coverage Δ
src/sagemaker/local/image.py 87.68% <0%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a667801...9b41da7. Read the comment docs.

@nadiaya nadiaya merged commit 1ec470f into aws:master Jul 12, 2018
knakad pushed a commit to knakad/sagemaker-python-sdk that referenced this pull request Dec 4, 2019
* fix: Disable hook for ps or mpi in TF
Co-Authored-By: Denis Davydenko <[email protected]>
knakad pushed a commit that referenced this pull request Dec 4, 2019
* fix: Disable hook for ps or mpi in TF
Co-Authored-By: Denis Davydenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants