feature: Add FailStep Support for Sagemaker Pipeline #2872

qidewenwhen · 2022-01-27T00:49:15Z

Description of changes: Add FailStep support for SageMaker model building pipeline.

Testing done: unit tests and integ tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter · 2022-01-27T01:03:15Z

Codecov Report

Merging #2872 (33411f1) into dev (3c5ea3a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #2872      +/-   ##
==========================================
+ Coverage   89.49%   89.50%   +0.01%     
==========================================
  Files         195      196       +1     
  Lines       16567    16583      +16     
==========================================
+ Hits        14826    14842      +16     
  Misses       1741     1741

Impacted Files	Coverage Δ
src/sagemaker/workflow/fail_step.py	`100.00% <100.00%> (ø)`
src/sagemaker/workflow/steps.py	`97.35% <100.00%> (+0.01%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c5ea3a...33411f1. Read the comment docs.

sagemaker-bot · 2022-01-27T01:10:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 527feed
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-27T02:03:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 527feed
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-27T02:50:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 527feed
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

EthanShouhanCheng

LGTM

sagemaker-bot · 2022-01-28T19:36:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a7e34eb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-28T20:17:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a7e34eb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-01-28T20:31:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a7e34eb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T00:21:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8a325cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T01:12:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7e80849
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T01:22:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8a325cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T01:55:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7e80849
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T02:22:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8a325cb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T02:22:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7e80849
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-04T00:34:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2332530
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-04T01:18:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2332530
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-04T01:32:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2332530
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-04T23:51:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fa9f008
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-05T00:46:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: fa9f008
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-05T01:01:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 63643f7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-05T01:34:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a48627e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-05T01:34:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: fa9f008
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-05T01:55:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 63643f7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-05T02:15:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a48627e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-05T02:35:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a48627e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-05T02:35:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 63643f7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

change: Add tests for Fail step API model change

* Clarified FailStep doc string * Added description of name and display_name * Grammar fix for error_message FailStep docstring * Fixed formatting issue for display_name FailStep docstring * Standardized style for all Steps entries and clarified FailStep parameter descriptions * Changed passive voice to active and finalized FailStep docstrings * Fixed code block formatting typos for steps.py Co-authored-by: qidewenwhen <[email protected]>

sagemaker-bot · 2022-02-09T22:23:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5946cff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-09T23:00:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5946cff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-09T23:26:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5946cff
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T03:01:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 33411f1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T03:34:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 33411f1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T03:37:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 33411f1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-16T04:36:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 33411f1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

staubhp approved these changes Jan 27, 2022

View reviewed changes

EthanShouhanCheng approved these changes Jan 27, 2022

View reviewed changes

jeniyat force-pushed the dev branch from f76b31c to 0a0b6e6 Compare January 27, 2022 18:38

qidewenwhen force-pushed the tioga_failstep branch from 527feed to a7e34eb Compare January 28, 2022 19:17

jeniyat force-pushed the dev branch 2 times, most recently from f5e6849 to 34b07c0 Compare January 29, 2022 23:28

qidewenwhen force-pushed the tioga_failstep branch from a7e34eb to 8a325cb Compare February 3, 2022 00:11

mufaddal-rohawala force-pushed the dev branch from 4fd04f1 to e3398d9 Compare February 4, 2022 04:44

mufaddal-rohawala force-pushed the dev branch 2 times, most recently from 96c01d7 to c437191 Compare February 5, 2022 00:08

qidewenwhen force-pushed the tioga_failstep branch from fa9f008 to 63643f7 Compare February 5, 2022 00:52

qidewenwhen force-pushed the tioga_failstep branch from 63643f7 to a48627e Compare February 5, 2022 01:14

jeniyat force-pushed the dev branch from 9d612a7 to bb7563f Compare February 7, 2022 23:40

Dewen Qi and others added 3 commits February 9, 2022 13:57

feature: Add FailStep Support for Sagemaker Pipeline

1a78631

change: Add tests for Fail step API model change

fix: fix format issues

5946cff

qidewenwhen force-pushed the tioga_failstep branch from a48627e to 5946cff Compare February 9, 2022 21:58

navinsoni approved these changes Feb 9, 2022

View reviewed changes

ahsan-z-khan approved these changes Feb 9, 2022

View reviewed changes

Merge branch 'dev' into tioga_failstep

33411f1

navinsoni merged commit cede5fa into aws:dev Feb 16, 2022

navinsoni pushed a commit that referenced this pull request Feb 16, 2022

feature: Add FailStep Support for Sagemaker Pipeline (#2872)

e48ee0f

navinsoni pushed a commit that referenced this pull request Feb 17, 2022

feature: Add FailStep Support for Sagemaker Pipeline (#2872)

fd520f4

qidewenwhen deleted the tioga_failstep branch February 22, 2022 19:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: Add FailStep Support for Sagemaker Pipeline #2872

feature: Add FailStep Support for Sagemaker Pipeline #2872

qidewenwhen commented Jan 27, 2022

codecov-commenter commented Jan 27, 2022 •

edited

Loading

sagemaker-bot commented Jan 27, 2022

sagemaker-bot commented Jan 27, 2022

sagemaker-bot commented Jan 27, 2022

EthanShouhanCheng left a comment

sagemaker-bot commented Jan 28, 2022

sagemaker-bot commented Jan 28, 2022

sagemaker-bot commented Jan 28, 2022

sagemaker-bot commented Feb 3, 2022

sagemaker-bot commented Feb 3, 2022

sagemaker-bot commented Feb 3, 2022

sagemaker-bot commented Feb 3, 2022

sagemaker-bot commented Feb 3, 2022

sagemaker-bot commented Feb 3, 2022

sagemaker-bot commented Feb 4, 2022

sagemaker-bot commented Feb 4, 2022

sagemaker-bot commented Feb 4, 2022

sagemaker-bot commented Feb 4, 2022

sagemaker-bot commented Feb 5, 2022

sagemaker-bot commented Feb 5, 2022

sagemaker-bot commented Feb 5, 2022

sagemaker-bot commented Feb 5, 2022

sagemaker-bot commented Feb 5, 2022

sagemaker-bot commented Feb 5, 2022

sagemaker-bot commented Feb 5, 2022

sagemaker-bot commented Feb 5, 2022

sagemaker-bot commented Feb 9, 2022

sagemaker-bot commented Feb 9, 2022

sagemaker-bot commented Feb 9, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 16, 2022

sagemaker-bot commented Feb 16, 2022

feature: Add FailStep Support for Sagemaker Pipeline #2872

feature: Add FailStep Support for Sagemaker Pipeline #2872

Conversation

qidewenwhen commented Jan 27, 2022

Merge Checklist

General

Tests

codecov-commenter commented Jan 27, 2022 • edited Loading

Codecov Report

sagemaker-bot commented Jan 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2022

AWS CodeBuild CI Report

EthanShouhanCheng left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 4, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 4, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 4, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 4, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 5, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 9, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

sagemaker-bot commented Feb 16, 2022

AWS CodeBuild CI Report

codecov-commenter commented Jan 27, 2022 •

edited

Loading