-
Notifications
You must be signed in to change notification settings - Fork 1.2k
change: use recommended inference image URI from Neo API #2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 34 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
dde8d00
fix: Set ProcessingStep upload locations deterministically to avoid c…
staubhp 0f72907
fix: Prevent repack_model script from referencing nonexistent directo…
staubhp 0bae071
fix: S3Input - add support for instance attributes (#2754)
mufaddal-rohawala 17fe93e
fix: typos and broken link (#2765)
mohamed-ali 0a8ca6a
fix: Model Registration with BYO scripts (#2797)
sreedes 08c3a7b
change: use recommended inference image uri from Neo API
HappyAmazonian 1d5a5dc
Merge branch 'master' into inference-url
shreyapandit edbf61f
change InferenceImage lookup in compilation job description API respo…
HappyAmazonian d28b89f
Merge branch 'inference-url' of https://github.com/HappyAmazonian/sag…
HappyAmazonian 185b4b0
fix: Add ContentType in test_auto_ml_describe
navinns 5ec2ff4
fix: Re-deploy static integ test endpoint if it is not found
cec05a5
Merge branch 'dev' into inference-url
mufaddal-rohawala 1312575
documentation :SageMaker model parallel library 1.6.0 API doc (#2814)
mchoi8739 6319bce
fix: fix kmeans test deletion sequence, increment lineage statics (#2…
mufaddal-rohawala f728e11
Merge branch 'dev' into inference-url
mufaddal-rohawala beeabbd
fix: Increment static lineage pipeline (#2817)
mufaddal-rohawala 005ded3
Merge branch 'dev' into inference-url
mufaddal-rohawala 81b77c8
fix: Model Registration with BYO scripts (#2797)
sreedes c8ca3b7
fix: Add ContentType in test_auto_ml_describe
navinns 7104337
fix: Re-deploy static integ test endpoint if it is not found
ad29a0c
documentation :SageMaker model parallel library 1.6.0 API doc (#2814)
mchoi8739 bbe6284
fix: fix kmeans test deletion sequence, increment lineage statics (#2…
mufaddal-rohawala b026769
fix: Increment static lineage pipeline (#2817)
mufaddal-rohawala 439d085
Merge branch 'dev' into inference-url
mufaddal-rohawala de9ad6b
improve unit tests
HappyAmazonian 6f98534
Merge branch 'inference-url' of https://github.com/HappyAmazonian/sag…
HappyAmazonian 87c1d2c
fix: Fix lineage query integ tests (#2823)
staubhp b31dd14
Merge branch 'dev' into inference-url
shreyapandit 8210375
fix: fixes unnecessary session call while generating pipeline definit…
xchen909 972a6d2
feature: Add models_v2 under lineage context (#2800)
yzhu0 7206b9e
feature: enable python 3.9 (#2802)
mufaddal-rohawala 127c964
change: Update CHANGELOG.md (#2842)
shreyapandit 554d735
fix: update pricing link (#2805)
ahsan-z-khan 431e853
Merge branch 'dev' into inference-url
HappyAmazonian 81af309
feature: Adds support for Serverless inference (#2831)
bhaoz a949e5f
feature: Add support for SageMaker lineage queries in action (#2853)
yzhu0 888153b
feature: Adds Lineage queries in artifact, context and trial componen…
yzhu0 b796a00
feature: Add EMRStep support in Sagemaker pipeline (#2848)
EthanShouhanCheng 9d25fcf
feature: Add support for SageMaker lineage queries context (#2830)
yzhu0 64e4690
fix: support specifying a facet by its column index
xgchena 814dd3d
doc: more documentation for serverless inference (#2859)
bhaoz 13aa858
Merge branch 'dev' into inference-url
HappyAmazonian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the impact if this is None? Would that prevent creation of model? Can we have a default instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the impact if this is None?
It would be
None
only if there is no recommended inference image. In that case, all other functions depending on this value ought to fail naturally since it is not valid.Would that prevent creation of model?
No. In model.compile function, it simply launches a compilation job.
Can we have a default instead?
From now on, we want user to use the
image_uri
provided by Neo service. Even if we decide to have a default image-uri later, we will make that change through our API response.