Implemented write_spmatrix_to_sparse_tensor #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 21, 2017 19:25
owen-t
reviewed
Dec 21, 2017
src/sagemaker/amazon/common.py
Outdated
| @@ -89,6 +108,46 @@ def write_numpy_to_dense_tensor(file, array, labels=None): | |||
| _write_recordio(file, record.SerializeToString()) | |||
|
|
|||
|
|
|||
| def write_numpy_to_sparse_tensor(file, array, labels=None): | |||
There was a problem hiding this comment.
Should this be write_spmatrix_to_sparse_tensor ?
|
|
||
| record = Record() | ||
| for row_idx in range(n_rows): | ||
| record.Clear() |
There was a problem hiding this comment.
Is there a reason this isn't done at the end of the for-loop?
There was a problem hiding this comment.
Full analogy to the write_numpy_to_dense_tensor function.
https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/amazon/common.py#L84
jesterhazy
reviewed
Dec 21, 2017
src/sagemaker/amazon/common.py
Outdated
| @@ -89,6 +108,46 @@ def write_numpy_to_dense_tensor(file, array, labels=None): | |||
| _write_recordio(file, record.SerializeToString()) | |||
|
|
|||
|
|
|||
| def write_numpy_to_sparse_tensor(file, array, labels=None): | |||
| """Writes a numpy array to a dense tensor""" | |||
There was a problem hiding this comment.
spmatrix not numpy array
src/sagemaker/amazon/common.py
Outdated
| @@ -89,6 +108,46 @@ def write_numpy_to_dense_tensor(file, array, labels=None): | |||
| _write_recordio(file, record.SerializeToString()) | |||
|
|
|||
|
|
|||
| def write_numpy_to_sparse_tensor(file, array, labels=None): | |||
meownoid
changed the title
owen-t
approved these changes
Dec 28, 2017
|
Thanks again for your submission |
|
@meownoid Merged in, thanks! |
laurenyu
added a commit
to laurenyu/sagemaker-python-sdk
that referenced
this pull request
May 31, 2018
Since publicly this is being known as "hyperparameter tuning" (or some variation of that), it doesn't make sense that we'd use "hpo" everywhere
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
BYOM Notebooks - Verbosity and other notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
write_numpy_to_sparse_tensorwhich supports anyscipy.sparsematrix (#27).