fix endpoint bug #2772

BasilBeirouti · 2021-11-24T23:34:11Z

Issue #, if available:

When an existing endpoint config exists with an identical name, throw an error instead of reusing it. The reason is that when the model.deploy() method is called, the model on which the deploy() method is called may not be the same model which is configured in the existing endpoint config. It is safer to throw an error, the same way that an error is thrown when an endpoint with the same name exists.

See the ticket for more information:
https://t.corp.amazon.com/P46903451

Testing done: unit tests all pass

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[ x] I have read the CONTRIBUTING doc
[ x] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
[ x] I used the commit message format described in CONTRIBUTING
[ x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[ x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[x ] I have checked that my tests are not configured for a specific region or account (if appropriate)
[ x] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter · 2021-11-24T23:43:53Z

Codecov Report

Merging #2772 (031d43f) into dev (e0b9d38) will decrease coverage by 0.00%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##              dev    #2772      +/-   ##
==========================================
- Coverage   88.71%   88.70%   -0.01%     
==========================================
  Files         167      167              
  Lines       14766    14765       -1     
==========================================
- Hits        13099    13098       -1     
  Misses       1667     1667

Impacted Files	Coverage Δ
src/sagemaker/session.py	`70.43% <77.77%> (-0.03%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b9d38...031d43f. Read the comment docs.

sagemaker-bot · 2021-11-24T23:50:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 031d43f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni · 2021-11-25T00:38:54Z

src/sagemaker/session.py

+        self.sagemaker_client.create_endpoint_config(**config_options)
+


How are you checking if the endpoint exists or not
How are you notifying customers if endpoint config already exists

your coverage is reducing. Please add unit tests

The endpoint check happens in the create_endpoint_config call in the boto3 layer. It is raised in that method call on line 3565 and propagates up the call stack to the endpoint_from_production_variants() method

sagemaker-bot · 2021-12-06T18:34:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2fdad08
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-06T19:25:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2991272
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-06T19:26:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c35da48
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-06T19:28:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 46baa68
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-06T20:05:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2991272
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-06T20:05:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 46baa68
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-06T20:16:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c35da48
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-06T20:18:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 46baa68
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-06T20:19:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2991272
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-06T22:37:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 46baa68
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Basil Beirouti <[email protected]>

* feature: allow conditional parellel builds (#2727) * fix endpoint bug (#2772) Co-authored-by: Basil Beirouti <[email protected]> * fix: local mode - support relative file structure (#2768) * prepare release v2.72.0 * update development version to v2.72.1.dev0 * fix: Set ProcessingStep upload locations deterministically to avoid c… (#2790) * fix: Prevent repack_model script from referencing nonexistent directories (#2755) Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> * fix: S3Input - add support for instance attributes (#2754) * fix: typos and broken link (#2765) Co-authored-by: Shreya Pandit <[email protected]> * prepare release v2.72.1 * update development version to v2.72.2.dev0 * fix: Model Registration with BYO scripts (#2797) Co-authored-by: Basil Beirouti <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: Basil Beirouti <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> * fix: Add ContentType in test_auto_ml_describe * fix: Re-deploy static integ test endpoint if it is not found * documentation :SageMaker model parallel library 1.6.0 API doc (#2814) * update smdmp change log, archive api doc for 1.4.0 and 1.5.0 * add no-index flags * finish api doc archive * fix: Set ProcessingStep upload locations deterministically to avoid c… (#2790) * fix: Prevent repack_model script from referencing nonexistent directories (#2755) Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> * fix: S3Input - add support for instance attributes (#2754) * fix: typos and broken link (#2765) Co-authored-by: Shreya Pandit <[email protected]> * add all api docs * add appendix, fix links * structural changes, fix links * incorporate feedback * prepare release v2.72.1 * update development version to v2.72.2.dev0 Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: Mohamed Ali Jamaoui <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: ci <ci> Co-authored-by: Jeniya Tabassum <[email protected]> * fix: fix kmeans test deletion sequence, increment lineage statics (#2815) * fix: Increment static lineage pipeline (#2817) * fix: Update CHANGELOG.md (#2832) * prepare release v2.72.2 * update development version to v2.72.3.dev0 * change: update master from dev (#2836) Co-authored-by: Basil Beirouti <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: Basil Beirouti <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Mohamed Ali Jamaoui <[email protected]> Co-authored-by: ci <ci> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: sreedes <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Miyoung <[email protected]> Co-authored-by: Ameen Khan <[email protected]> Co-authored-by: Zhankui Lu <[email protected]> Co-authored-by: Xiaoguang Chen <[email protected]> Co-authored-by: Jonathan Guinegagne <[email protected]> Co-authored-by: Zhankui Lu <[email protected]> Co-authored-by: Yifei Zhu <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> * prepare release v2.72.3 * update development version to v2.72.4.dev0 * fix: fixes unnecessary session call while generating pipeline definition for lambda step (#2824) * feature: Add models_v2 under lineage context (#2800) * feature: enable python 3.9 (#2802) Co-authored-by: Ahsan Khan <[email protected]> * change: Update CHANGELOG.md (#2842) * fix: update pricing link (#2805) Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: Basil Beirouti <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: Basil Beirouti <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Mohamed Ali Jamaoui <[email protected]> Co-authored-by: ci <ci> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: sreedes <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Miyoung <[email protected]> Co-authored-by: Ameen Khan <[email protected]> Co-authored-by: Zhankui Lu <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Xiaoguang Chen <[email protected]> Co-authored-by: Jonathan Guinegagne <[email protected]> Co-authored-by: Zhankui Lu <[email protected]> Co-authored-by: Yifei Zhu <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> * doc: Document the available ExecutionVariables (#2807) * fix: Remove duplicate vertex/edge in query lineage (#2784) * feature: Support model pipelines in CreateModelStep (#2845) Co-authored-by: Payton Staub <[email protected]> * feature: support JsonGet/Join parameterization in tuning step Hyperparameters (#2833) * doc: Enhance smddp 1.2.2 doc (#2852) * feature: support checkpoint to be passed from estimator (#2849) Co-authored-by: marckarp <[email protected]> * fix: allow kms_key to be passed for processing step (#2779) * feature: Adds support for Serverless inference (#2831) * feature: Add support for SageMaker lineage queries in action (#2853) * feature: Adds Lineage queries in artifact, context and trial components (#2838) * feature: Add EMRStep support in Sagemaker pipeline (#2848) Co-authored-by: chenxy <[email protected]> * prepare release v2.73.0 * update development version to v2.73.1.dev0 * feature: Add support for SageMaker lineage queries context (#2830) * fix: support specifying a facet by its column index Currently the Clarify BiasConfig only accepts facet name. Actually Clarify analysis configuration supports both name and index. This commit adds the same support to BiasConfig. * doc: more documentation for serverless inference (#2859) * prepare release v2.74.0 * update development version to v2.74.1.dev0 * Add deprecation warning in Clarify DataConfig (#2847) * feature: Update instance types for integ test (#2881) * feature: Adds support for async inference (#2846) * fix: update to incorporate black v22, pin tox versions (#2889) Co-authored-by: Mufaddal Rohawala <[email protected]> * make black happy Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: Basil Beirouti <[email protected]> Co-authored-by: Basil Beirouti <[email protected]> Co-authored-by: ci <ci> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Payton Staub <[email protected]> Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mohamed Ali Jamaoui <[email protected]> Co-authored-by: Shreya Pandit <[email protected]> Co-authored-by: sreedes <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Miyoung <[email protected]> Co-authored-by: Jeniya Tabassum <[email protected]> Co-authored-by: Ameen Khan <[email protected]> Co-authored-by: Zhankui Lu <[email protected]> Co-authored-by: Xiaoguang Chen <[email protected]> Co-authored-by: Jonathan Guinegagne <[email protected]> Co-authored-by: Zhankui Lu <[email protected]> Co-authored-by: Yifei Zhu <[email protected]> Co-authored-by: Qingzi-Lan <[email protected]> Co-authored-by: Xinghan Chen <[email protected]> Co-authored-by: Navin Soni <[email protected]> Co-authored-by: Tulio Casagrande <[email protected]> Co-authored-by: jerrypeng7773 <[email protected]> Co-authored-by: marckarp <[email protected]> Co-authored-by: marckarp <[email protected]> Co-authored-by: jayatalr <[email protected]> Co-authored-by: bhaoz <[email protected]> Co-authored-by: Ethan Cheng <[email protected]> Co-authored-by: chenxy <[email protected]> Co-authored-by: Xiaoguang Chen <[email protected]> Co-authored-by: keerthanvasist <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]> Co-authored-by: Shreya Pandit <[email protected]>

navinsoni reviewed Nov 25, 2021

View reviewed changes

BasilBeirouti changed the base branch from dev to master December 6, 2021 18:14

BasilBeirouti force-pushed the fix-endpoint-config branch from 031d43f to 2fdad08 Compare December 6, 2021 18:14

mufaddal-rohawala changed the base branch from master to dev December 6, 2021 19:09

BasilBeirouti force-pushed the fix-endpoint-config branch from 2991272 to c35da48 Compare December 6, 2021 19:12

mufaddal-rohawala previously approved these changes Dec 6, 2021

View reviewed changes

fix endpoint bug

46baa68

BasilBeirouti dismissed mufaddal-rohawala’s stale review via 46baa68 December 6, 2021 19:14

BasilBeirouti force-pushed the fix-endpoint-config branch from c35da48 to 46baa68 Compare December 6, 2021 19:14

ahsan-z-khan approved these changes Dec 6, 2021

View reviewed changes

mufaddal-rohawala approved these changes Dec 6, 2021

View reviewed changes

BasilBeirouti merged commit 1ff8ae3 into dev Dec 6, 2021

BasilBeirouti deleted the fix-endpoint-config branch December 6, 2021 22:56

BasilBeirouti added a commit that referenced this pull request Dec 8, 2021

fix endpoint bug (#2772)

565e70e

Co-authored-by: Basil Beirouti <[email protected]>

shreyapandit pushed a commit that referenced this pull request Jan 11, 2022

fix endpoint bug (#2772)

1489363

Co-authored-by: Basil Beirouti <[email protected]>

EthanShouhanCheng pushed a commit to SissiChenxy/sagemaker-python-sdk that referenced this pull request Jan 11, 2022

fix endpoint bug (aws#2772)

4d44f4f

Co-authored-by: Basil Beirouti <[email protected]>

mufaddal-rohawala mentioned this pull request Apr 20, 2022

XGBoostModel attempts to deploy the wrong model object #2112

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix endpoint bug #2772

fix endpoint bug #2772

BasilBeirouti commented Nov 24, 2021

codecov-commenter commented Nov 24, 2021 •

edited

Loading

sagemaker-bot commented Nov 24, 2021

navinsoni Nov 25, 2021

navinsoni Nov 25, 2021

BasilBeirouti Nov 29, 2021

sagemaker-bot commented Dec 6, 2021

sagemaker-bot commented Dec 6, 2021

sagemaker-bot commented Dec 6, 2021

sagemaker-bot commented Dec 6, 2021

sagemaker-bot commented Dec 6, 2021

sagemaker-bot commented Dec 6, 2021

sagemaker-bot commented Dec 6, 2021

sagemaker-bot commented Dec 6, 2021

sagemaker-bot commented Dec 6, 2021

sagemaker-bot commented Dec 6, 2021

		self.sagemaker_client.create_endpoint_config(**config_options)

fix endpoint bug #2772

fix endpoint bug #2772

Conversation

BasilBeirouti commented Nov 24, 2021

Merge Checklist

General

Tests

codecov-commenter commented Nov 24, 2021 • edited Loading

Codecov Report

sagemaker-bot commented Nov 24, 2021

AWS CodeBuild CI Report

navinsoni Nov 25, 2021

Choose a reason for hiding this comment

navinsoni Nov 25, 2021

Choose a reason for hiding this comment

BasilBeirouti Nov 29, 2021

Choose a reason for hiding this comment

sagemaker-bot commented Dec 6, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 6, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 6, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 6, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 6, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 6, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 6, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 6, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 6, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 6, 2021

AWS CodeBuild CI Report

codecov-commenter commented Nov 24, 2021 •

edited

Loading