feature: Add profile_name support for Feature Store ingestion #2744

imingtsou · 2021-11-01T18:48:21Z

Issue #, if available:

Description of changes:
Add profile_name for Feature Store ingestion so user can specify which credential to use for PutRecord.
Testing done:
Added one unit test and passed in Python 3.6/3.7/3.8.
I wrote a piece of sample ingestion with and without profile_name specified and both show the expected behavior.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2021-11-01T19:02:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 64a3573
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/feature_store/feature_group.py

alex-tang

Can you add more detail to the testing done section? I.e. describe the test cases did you performed.

sagemaker-bot · 2021-11-01T19:59:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 64a3573
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-11-01T23:14:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3048619
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-11-01T23:48:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 97d1443
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-11-01T23:58:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3048619
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-11-02T00:14:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3048619
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-11-02T00:38:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 97d1443
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-11-12T00:05:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 59a58ef
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-11-18T18:00:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4dd2aa0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2021-11-18T18:53:03Z

Codecov Report

Merging #2744 (a7b4973) into master (99f023e) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #2744   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files         167      167           
  Lines       14766    14767    +1     
=======================================
+ Hits        13099    13101    +2     
+ Misses       1667     1666    -1

Impacted Files	Coverage Δ
src/sagemaker/feature_store/feature_group.py	`76.96% <50.00%> (+0.60%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99f023e...a7b4973. Read the comment docs.

sagemaker-bot · 2021-11-18T18:55:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a9bbf4c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-11-18T19:38:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a9bbf4c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/feature_store/feature_group.py

sagemaker-bot · 2021-12-01T06:15:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9176fd5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-01T06:15:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3c08b59
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-01T06:20:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9176fd5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-01T06:21:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9176fd5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-01T06:58:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 79e03f1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-01T07:04:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 79e03f1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-01T07:04:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 79e03f1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-01T08:01:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a7b4973
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

.coveragerc

sagemaker-bot · 2021-12-02T18:50:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a54ccfe
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-03T20:35:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5893b87
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-12-03T21:15:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5893b87
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Shreya Pandit <[email protected]>

alex-tang reviewed Nov 1, 2021

View reviewed changes

src/sagemaker/feature_store/feature_group.py Outdated Show resolved Hide resolved

alex-tang reviewed Nov 1, 2021

View reviewed changes

imingtsou force-pushed the profile branch from 64a3573 to 3048619 Compare November 1, 2021 23:09

shreyapandit changed the base branch from master to dev November 5, 2021 17:23

imingtsou force-pushed the profile branch from 97d1443 to 59a58ef Compare November 11, 2021 23:58

imingtsou changed the base branch from dev to master November 18, 2021 17:49

imingtsou force-pushed the profile branch from 4dd2aa0 to a9bbf4c Compare November 18, 2021 18:40

alex-tang previously approved these changes Nov 18, 2021

View reviewed changes

mufaddal-rohawala requested changes Nov 19, 2021

View reviewed changes

src/sagemaker/feature_store/feature_group.py Outdated Show resolved Hide resolved

src/sagemaker/feature_store/feature_group.py Outdated Show resolved Hide resolved

imingtsou dismissed alex-tang’s stale review via 3c08b59 December 1, 2021 06:05

imingtsou force-pushed the profile branch 2 times, most recently from 3c08b59 to 9176fd5 Compare December 1, 2021 06:08

imingtsou requested a review from mufaddal-rohawala December 1, 2021 06:42

imingtsou force-pushed the profile branch from 9176fd5 to 79e03f1 Compare December 1, 2021 06:50

ahsan-z-khan suggested changes Dec 1, 2021

View reviewed changes

.coveragerc Outdated Show resolved Hide resolved

Add profile_name support for Feature Store ingestion

a54ccfe

imingtsou force-pushed the profile branch from a7b4973 to a54ccfe Compare December 2, 2021 18:33

imingtsou requested a review from ahsan-z-khan December 2, 2021 18:33

mufaddal-rohawala approved these changes Dec 2, 2021

View reviewed changes

Merge branch 'master' into profile

5893b87

ahsan-z-khan approved these changes Dec 3, 2021

View reviewed changes

mufaddal-rohawala changed the title ~~Add profile_name support for Feature Store ingestion~~ feature: Add profile_name support for Feature Store ingestion Dec 3, 2021

mufaddal-rohawala merged commit e4b851d into aws:master Dec 3, 2021

imingtsou deleted the profile branch December 3, 2021 21:42

BasilBeirouti pushed a commit that referenced this pull request Dec 6, 2021

feature: Add profile_name support for Feature Store ingestion (#2744)

59ff81d

Co-authored-by: Shreya Pandit <[email protected]>

EthanShouhanCheng pushed a commit to SissiChenxy/sagemaker-python-sdk that referenced this pull request Jan 11, 2022

feature: Add profile_name support for Feature Store ingestion (aws#2744)

193ed0e

Co-authored-by: Shreya Pandit <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: Add profile_name support for Feature Store ingestion #2744

feature: Add profile_name support for Feature Store ingestion #2744

imingtsou commented Nov 1, 2021 •

edited

Loading

sagemaker-bot commented Nov 1, 2021

alex-tang left a comment

sagemaker-bot commented Nov 1, 2021

sagemaker-bot commented Nov 1, 2021

sagemaker-bot commented Nov 1, 2021

sagemaker-bot commented Nov 1, 2021

sagemaker-bot commented Nov 2, 2021

sagemaker-bot commented Nov 2, 2021

sagemaker-bot commented Nov 12, 2021

sagemaker-bot commented Nov 18, 2021

codecov-commenter commented Nov 18, 2021 •

edited

Loading

sagemaker-bot commented Nov 18, 2021

sagemaker-bot commented Nov 18, 2021

sagemaker-bot commented Dec 1, 2021

sagemaker-bot commented Dec 1, 2021

sagemaker-bot commented Dec 1, 2021

sagemaker-bot commented Dec 1, 2021

sagemaker-bot commented Dec 1, 2021

sagemaker-bot commented Dec 1, 2021

sagemaker-bot commented Dec 1, 2021

sagemaker-bot commented Dec 1, 2021

sagemaker-bot commented Dec 2, 2021

sagemaker-bot commented Dec 3, 2021

sagemaker-bot commented Dec 3, 2021

feature: Add profile_name support for Feature Store ingestion #2744

feature: Add profile_name support for Feature Store ingestion #2744

Conversation

imingtsou commented Nov 1, 2021 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

alex-tang left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Nov 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Nov 2, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Nov 2, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Nov 12, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Nov 18, 2021

AWS CodeBuild CI Report

codecov-commenter commented Nov 18, 2021 • edited Loading

Codecov Report

sagemaker-bot commented Nov 18, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Nov 18, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 1, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 2, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 3, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Dec 3, 2021

AWS CodeBuild CI Report

imingtsou commented Nov 1, 2021 •

edited

Loading

codecov-commenter commented Nov 18, 2021 •

edited

Loading