Make the metric_names list optional in TrainingJobAnalytics object. #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenyu
approved these changes
Jul 2, 2018
| if metric_names: | ||
| self._metric_names = metric_names | ||
| else: | ||
| self._metric_names = self._metric_names_for_training_job() |
There was a problem hiding this comment.
could be done in one line:
self._metric_names = metric_names or self._metric_names_for_training_job()| tuning_job_arn = training_description.get('TuningJobArn', None) | ||
| if not tuning_job_arn: | ||
| raise ValueError( | ||
| "No metrics available. Training Job Analytics only available through Hyperparameter Tuning Jobs" |
nadiaya
approved these changes
Jul 2, 2018
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
=========================================
+ Coverage 92.43% 92.5% +0.07%
=========================================
Files 49 49
Lines 3279 3297 +18
=========================================
+ Hits 3031 3050 +19
+ Misses 248 247 -1
Continue to review full report at Codecov.
|
nadiaya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #273
Description of changes: When TrainingJobAnalytics object, the metric_names list is now optional. If not specified, it will use all configured metrics. To discover them, it looks for a hyperparameter tuning job associated with the training job, and finds the metric definitions there.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.