Skip to content

Fix local mode error message #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Fix local mode error message #272

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
496c65b
Fix error handling in local mode image
laurenyu Jul 1, 2018
ec0b9bb
Update changelog
laurenyu Jul 1, 2018
dec9fe6
Add unit test
laurenyu Jul 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ CHANGELOG
========

* bug-fix: Session: include role path in ``get_execution_role()`` result
* bug-fix: Local Mode: fix RuntimeError handling

1.5.2
=====
Expand Down
4 changes: 2 additions & 2 deletions src/sagemaker/local/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def train(self, input_data_config, hyperparameters):
except RuntimeError as e:
# _stream_output() doesn't have the command line. We will handle the exception
# which contains the exit code and append the command line to it.
msg = "Failed to run: %s, %s" % (compose_command, e.message)
msg = "Failed to run: %s, %s" % (compose_command, str(e))
raise RuntimeError(msg)

s3_artifacts = self.retrieve_artifacts(compose_data)
Expand Down Expand Up @@ -516,7 +516,7 @@ def run(self):
except RuntimeError as e:
# _stream_output() doesn't have the command line. We will handle the exception
# which contains the exit code and append the command line to it.
msg = "Failed to run: %s, %s" % (self.command, e.message)
msg = "Failed to run: %s, %s" % (self.command, str(e))
raise RuntimeError(msg)

def down(self):
Expand Down