Skip to content

feature: support configurable retry for pipeline steps #2662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 80 commits into from
Oct 12, 2021

Conversation

jerrypeng7773
Copy link
Contributor

Issue #, if available:

Description of changes:

support configurable retry for pipeline steps

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jerrypeng7773 and others added 30 commits May 10, 2021 20:18
ci and others added 8 commits September 23, 2021 23:21
* added pytorch 1.8.1 for supporting huggingface

* fix: add pytorch 1.8.1 for huggingface

* fix: add pytorch 1.8.1 for huggingface

* refactored code for flake

* refactored code for docstyle

* fix: add alias for pytorch 1.8

* update to master

* add version alias for pytorch1.8 in huggingface.json

* add version alias for pytorch1.8 in huggingface.json

* removed empty file, corrected grammar

* removed empty line in test_estimator

* removed empty line in test_estimator

* removed empty line in test_estimator

Co-authored-by: Tabassum <[email protected]>
Co-authored-by: Ahsan Khan <[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: fb5140e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

danabens
danabens previously approved these changes Sep 24, 2021
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 1e24b0f
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: df628d7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Member

@ahsan-z-khan ahsan-z-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 7fee07b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ahsan-z-khan ahsan-z-khan changed the title support configurable retry for pipeline steps feature: support configurable retry for pipeline steps Oct 12, 2021
@ahsan-z-khan ahsan-z-khan merged commit 82f1ba7 into aws:master Oct 12, 2021
EthanShouhanCheng pushed a commit to SissiChenxy/sagemaker-python-sdk that referenced this pull request Jan 11, 2022
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Ahsan Khan <[email protected]>
Co-authored-by: ci <ci>
Co-authored-by: Navin Soni <[email protected]>
Co-authored-by: Tabassum <[email protected]>
Co-authored-by: apogupta2018 <[email protected]>
Co-authored-by: Dana Benson <[email protected]>
Co-authored-by: Julia Kroll <[email protected]>
Co-authored-by: Michael Boesl <[email protected]>
Co-authored-by: cansun <[email protected]>
Co-authored-by: Jeniya Tabassum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants