fix: add checks for ExecutionRole in UserSettings, adds more unit tests #2657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shreyapandit
changed the title
shreyapandit
changed the title
ahsan-z-khan
changed the title
ahsan-z-khan
previously approved these changes
Sep 24, 2021
jeniyat
previously approved these changes
Sep 24, 2021
shreyapandit
dismissed stale reviews from jeniyat and ahsan-z-khan
via
0e42e28
mufaddal-rohawala
previously approved these changes
Sep 25, 2021
navinsoni
reviewed
Sep 26, 2021
shreyapandit
requested review from
navinsoni,
ahsan-z-khan and
mufaddal-rohawala
navinsoni
approved these changes
Sep 26, 2021
jeniyat
approved these changes
Sep 27, 2021
EthanShouhanCheng
pushed a commit
to SissiChenxy/sagemaker-python-sdk
that referenced
this pull request
Jan 11, 2022
…ts (aws#2657) * Adds check for ExecutionRole in UserSettings; Add more unit tests * Enhance check with default values * remove role default * update unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add additional safety check for Execution Role when fetching from UserSettings since it is not a required parameter. Additionally, add more unit tests for all the scenarios.
Testing done:
Ran unit tests
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.