Skip to content

deprecation: Remove stale S3DownloadMode from test_session.py #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

navinsoni
Copy link
Contributor

@navinsoni navinsoni commented Aug 26, 2021

Issue #, if available:

Description of changes:
This PR is to remove stale S3DownloadMode field present in S3Input.
This field was removed from code in this PR

Testing done:

===================================================================================== 4999 passed, 447 skipped, 1 xfailed, 1 xpassed, 3046 warnings in 338.24s (0:05:38) =====================================================================================
py38 run-test: commands[1] | coverage report -i --fail-under=86


TOTAL 14751 1518 90%
__________________________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________________________
black-format: commands succeeded
flake8: commands succeeded
pylint: commands succeeded
docstyle: commands succeeded
sphinx: commands succeeded
doc8: commands succeeded
twine: commands succeeded
ERROR: py36: InterpreterNotFound: python3.6
ERROR: py37: InterpreterNotFound: python3.7
py38: commands succeeded

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@navinsoni navinsoni marked this pull request as ready for review August 26, 2021 18:44
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: f77ed77
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@navinsoni navinsoni changed the title Remove stale S3DownloadMode from test_session.py fix: Remove stale S3DownloadMode from test_session.py Aug 26, 2021
@navinsoni navinsoni changed the title fix: Remove stale S3DownloadMode from test_session.py deprecation: Remove stale S3DownloadMode from test_session.py Aug 26, 2021
Copy link
Member

@ahsan-z-khan ahsan-z-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shreyapandit
Copy link
Contributor

Thanks for taking this on!

@shreyapandit shreyapandit merged commit 0ce904c into aws:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants