Fix docs about s3_input usage #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiaya
reviewed
Jun 26, 2018
src/sagemaker/tensorflow/README.rst
Outdated
| @@ -482,6 +482,7 @@ Required argument | |||
|
|
|||
| - ``str``: An S3 URI, for example ``s3://my-bucket/my-training-data``, which indicates the dataset's location. | |||
| - ``dict[str, str]``: A dictionary mapping channel names to S3 locations, for example ``{'train': 's3://my-bucket/my-training-data/train', 'test': 's3://my-bucket/my-training-data/test'}`` | |||
| - ``sagemaker.session.s3_input``: channel configuration for S3 data sources that can provide additional information about the training dataset. See `the API docs <https://sagemaker.readthedocs.io/en/latest/session.html#sagemaker.session.s3_input>`_ for full details. | |||
There was a problem hiding this comment.
Doesn't it also contain dataset (besides additional information about it)?
nadiaya
approved these changes
Jun 26, 2018
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
It will generate type error without int
knakad
pushed a commit
to knakad/sagemaker-python-sdk
that referenced
this pull request
Nov 27, 2019
* change: add support for xgboost version 0.90-2 * fix: remove duplicate rule in test_debugger.py:test_mxnet_with_all_rules_and_configs
knakad
pushed a commit
to knakad/sagemaker-python-sdk
that referenced
this pull request
Dec 4, 2019
* change: add support for xgboost version 0.90-2 * fix: remove duplicate rule in test_debugger.py:test_mxnet_with_all_rules_and_configs
knakad
pushed a commit
that referenced
this pull request
Dec 4, 2019
* change: add support for xgboost version 0.90-2 * fix: remove duplicate rule in test_debugger.py:test_mxnet_with_all_rules_and_configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added mention of the
s3_inputtype forfit()with TF - we got contacted about there being confusion around that. Also fixed the description for compression type based on the AWS docsMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.