fix: update `sagemaker.serverless` integration test #2533

bveeramani · 2021-07-22T04:15:20Z

Issue #, if available:

Description of changes:
"CODEBUILD_BUILD_ID" not in os.environ was evaluating True during builds, so the test was getting skipped.

Made two fixes:

Stored cat image in S3 (it was previously hosted at some third-party website)
Changed the condition for skipping the test

Note that this branch is based on the branch bveeramani:rename-delete-endpoint. See #2529.

Testing done:
Integration test.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2021-07-22T04:18:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5f1131c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-22T04:18:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 837b45e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…emaker-python-sdk into fix-serverless-integ-test

sagemaker-bot · 2021-07-22T04:32:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 98a8556
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-22T04:50:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 837b45e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-22T04:52:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5f1131c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-22T04:53:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5f1131c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-22T04:55:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 837b45e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-22T04:56:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 98a8556
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-22T05:00:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 837b45e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-22T05:00:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5f1131c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-22T05:01:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 98a8556
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-22T05:06:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 98a8556
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-22T08:00:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 98a8556
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shreyapandit

Pending refactoring to see how we can automate ingestion of the ECR URL (which needs to be refactored anyways across the codebase), these changes look good to me

sagemaker-bot · 2021-07-28T00:37:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 62b6bf7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-28T01:04:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 62b6bf7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T09:32:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e8c59e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T09:44:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e8c59e5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T09:52:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e8c59e5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T10:08:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 42fdd2b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T10:08:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b2156fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T10:17:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 42fdd2b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T10:17:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b2156fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T10:41:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 42fdd2b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T10:46:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b2156fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T10:49:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b2156fd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T10:52:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 42fdd2b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T10:53:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b2156fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T19:11:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 318b1d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T19:12:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c161878
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T19:20:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 318b1d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T19:36:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c161878
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T19:38:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c161878
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T19:46:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c161878
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T19:51:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 318b1d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T19:56:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 318b1d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-04T20:22:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 318b1d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ahsan-z-khan · 2021-08-04T22:24:54Z

tests/conftest.py

+def account(boto_session):
+    return boto_session.client("sts").get_caller_identity()["Account"]
+
+


Do we need to create these two fixtures?

Can't we just use boto_session to access account and region ?

Any benefit for creating this one?

For account, it's to reduce code duplication. While it's true we could use boto_session.client("sts").get_caller_identity()["Account"] every time we want to access the account ID, IMO setting up a fixture for the account is a cleaner implementation (the account fixture is used more than once).

With respect to the region fixture, there's less of a case for that. I subjectively feel it simplifies the implementation, but I also see the argument for why it may be unnecessary. If you feel that we should get rid of it, I'd be okay with doing so.

bveeramani added 3 commits July 21, 2021 16:18

Rename delete_endpoint as delete_predictor

fab0196

Update test_serverless.py

bc5a586

Update test_serverless.py

5f1131c

bveeramani self-assigned this Jul 22, 2021

Merge branch 'master' into fix-serverless-integ-test

837b45e

bveeramani marked this pull request as draft July 22, 2021 04:15

bveeramani added serverless type: bug labels Jul 22, 2021

bveeramani requested a review from shreyapandit July 22, 2021 04:17

bveeramani added 2 commits July 21, 2021 23:20

Appease lint

2689fd6

Merge branch 'fix-serverless-integ-test' of github.com:bveeramani/sag…

98a8556

…emaker-python-sdk into fix-serverless-integ-test

bveeramani marked this pull request as ready for review July 22, 2021 04:23

bveeramani marked this pull request as draft July 22, 2021 17:56

shreyapandit previously approved these changes Jul 28, 2021

View reviewed changes

Merge branch 'master' into fix-serverless-integ-test

62b6bf7

bveeramani added 2 commits August 4, 2021 05:06

Update test_serverless.py

42fdd2b

Update test_serverless.py

b2156fd

bveeramani added 2 commits August 4, 2021 14:00

Fix tests

c161878

Merge branch 'master' into fix-serverless-integ-test

318b1d7

shreyapandit approved these changes Aug 4, 2021

View reviewed changes

ahsan-z-khan reviewed Aug 4, 2021

View reviewed changes

ahsan-z-khan approved these changes Aug 4, 2021

View reviewed changes

ahsan-z-khan changed the title ~~fix: Fix sagemaker.serverless integration test~~ fix: update sagemaker.serverless integration test Aug 4, 2021

ahsan-z-khan merged commit cb8bc65 into aws:master Aug 4, 2021

		def account(boto_session):
		return boto_session.client("sts").get_caller_identity()["Account"]

fix: update sagemaker.serverless integration test #2533

fix: update sagemaker.serverless integration test #2533

Conversation

bveeramani commented Jul 22, 2021 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 22, 2021

AWS CodeBuild CI Report

shreyapandit left a comment

Choose a reason for hiding this comment

sagemaker-bot commented Jul 28, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jul 28, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 4, 2021

fix: update `sagemaker.serverless` integration test #2533

fix: update `sagemaker.serverless` integration test #2533

bveeramani commented Jul 22, 2021 •

edited

Loading

bveeramani Aug 4, 2021 •

edited

Loading