-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feature: support JsonGet for all step types #2506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
868db55
add helper function to generate no-op (data ingestion only) recipe
jerrypeng7773 21bedbb
Merge branch 'aws:master' into master
jerrypeng7773 854dd10
separate flow generation by source input type + move generation helpe…
jerrypeng7773 8798b65
Merge branch 'aws:master' into master
jerrypeng7773 69ae4bd
create an internal helper function to generate output node
jerrypeng7773 a6a8449
Merge branch 'master' of github.com:jerrypeng7773/sagemaker-python-sdk
jerrypeng7773 2aa256e
Merge branch 'aws:master' into master
jerrypeng7773 06557a8
add ingestion test using dw processor via pipeline execution
jerrypeng7773 dcbfd13
Merge branch 'aws:master' into master
jerrypeng7773 fc6522e
verify the fg query df
jerrypeng7773 b6f9371
Merge branch 'master' into master
ahsan-z-khan 86fa47d
fix tests
jerrypeng7773 05ccfa6
Merge branch 'master' into master
ahsan-z-khan 0716e9f
Merge branch 'aws:master' into master
jerrypeng7773 7ca5af4
add tuning step support
jerrypeng7773 8cf18b8
fix docstyle check
jerrypeng7773 1f95b82
add helper function to get tuning step top performing model s3 uri
jerrypeng7773 1b9d66b
Merge branch 'aws:master' into master
jerrypeng7773 603b934
Merge branch 'aws:master' into master
jerrypeng7773 664f2a8
Merge branch 'master' of github.com:jerrypeng7773/sagemaker-python-sdk
jerrypeng7773 a8755ec
Merge branch 'master' into master
apogupta2018 e25d36c
Merge branch 'aws:master' into master
jerrypeng7773 db83c4b
make JsonGet compatible to all steps and put it into functions.py
jerrypeng7773 003de65
Merge branch 'master' into fix-issue-2426
apogupta2018 1c1f2d2
Merge branch 'master' into fix-issue-2426
ahsan-z-khan 5ed6d29
Merge branch 'master' into fix-issue-2426
ahsan-z-khan 989875e
Merge branch 'master' into fix-issue-2426
ahsan-z-khan 10d0fc7
Merge branch 'master' into fix-issue-2426
shreyapandit fcd2615
Merge branch 'master' into fix-issue-2426
shreyapandit d3f5761
Merge branch 'master' into fix-issue-2426
shreyapandit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this class, we are introducing the same duplicated block of code here as in condition_step.py, while marking the block there as deprecated. The class itself is the same. If we still plan to reuse the same code in condition_step as well as here, why can't we pull this out somewhere common, like utils, where both can import it