feature: add pytorch 1.5.1 eia configuration #2441

jbarz1 · 2021-06-11T18:01:05Z

Issue #, if available:

Description of changes:

Add image ECR registries for Elastic inference pytorch 1.5.1
Limit registries to regions where Elastic inference is supported.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

also fix regions for 1.3.1 to only those regions that have elastic inference in service

sagemaker-bot · 2021-06-11T18:12:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e487a03
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-11T18:39:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e487a03
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-11T18:41:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e487a03
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-11T18:45:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e487a03
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-11T18:56:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e487a03
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jbarz1 · 2021-06-11T20:42:28Z

failure is due to default handler in the DLC. The handler has been. fixed here.

aws/deep-learning-containers#814

Will need to wait for a release

ahsan-z-khan · 2021-08-10T21:35:00Z

@jbarz1 do we still need to merge this?

sagemaker-bot · 2021-08-10T21:45:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3ac5bf8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-10T22:09:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3ac5bf8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-10T22:11:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3ac5bf8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-10T22:20:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3ac5bf8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-10T23:31:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3ac5bf8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-12T20:51:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fecc3c8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jbarz1 · 2021-08-12T21:00:19Z

@jbarz1 do we still need to merge this?

Hey, yea we do need to merge this

ahsan-z-khan · 2021-08-12T21:33:44Z

@jbarz1 do we still need to merge this?

Hey, yea we do need to merge this

@jbarz1 , do you know why are we removing the regions from 1.3.1 ?

saimidu · 2021-08-12T23:10:35Z

src/sagemaker/image_uri_config/pytorch.json

@@ -26,16 +25,22 @@
                    "eu-central-1": "763104351884",
                    "eu-north-1": "763104351884",


All these regions, apart from ap-northeast-1, ap-northeast-2, eu-west-1, us-east-1, us-east-2, and us-west-2, cannot create EI inference endpoints because EI is unsupported in those regions.

The list of regions for PT 1.5.1 is correct, and the list of regions for PT 1.3.1 needs to be updated to match that.

Reference: https://aws.amazon.com/machine-learning/elastic-inference/pricing/

Thanks for clarifying! As discussed, this does lead to a change in customer experience whereby if these regions are non existent, we won't be able to construct the image URIs for the customer properly, and it will diverge from the current error thrown in this scenario. Since we aren't supporting EIA in these regions prior to this, I think this is a correct bug fix in that regard; but we should in general think of introducing a framework which checks for feature/region compatibility and alerts users accordingly, which will allow for easier and more seamless deprecation

saimidu · 2021-08-12T23:35:35Z

tests/unit/sagemaker/image_uris/test_dlc_frameworks.py

        uri = image_uris.retrieve(region=region, **base_args)

        expected = expected_uris.framework_uri(
            "pytorch-inference-eia",
            pytorch_eia_version,
-            account,
+            DLC_ACCOUNT,


I would recommend looking up the account id from the DLC_ACCOUNT and DLC_ALTERNATE_REGION_ACCOUNTS variables, because we never know when opt-in regions or other partitions might receive EI support.

I guess something like account = DLC_ALTERNATE_REGION_ACCOUNTS.get(region, DLC_ACCOUNT) would be good.

sagemaker-bot · 2021-08-13T06:00:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1abdcd9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-13T06:16:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 02ad179
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

John Barboza and others added 4 commits February 2, 2021 15:54

add pytorch 1.5.1 eia configuration

d625ebf

also fix regions for 1.3.1 to only those regions that have elastic inference in service

fix unit tests

f3eaf1b

Merge branch 'master' into eia_151

4bb5338

Merge remote-tracking branch 'aws/master' into eia_151

e487a03

Merge branch 'master' into eia_151

3ac5bf8

ahsan-z-khan added the Pending information label Aug 10, 2021

ahsan-z-khan added PyTorch and removed Pending information labels Aug 10, 2021

ahsan-z-khan previously approved these changes Aug 12, 2021

View reviewed changes

Merge branch 'master' into eia_151

fecc3c8

saimidu reviewed Aug 12, 2021

View reviewed changes

shreyapandit previously approved these changes Aug 13, 2021

View reviewed changes

look up regional accounts for eia if needed

1abdcd9

jbarz1 dismissed shreyapandit’s stale review via 1abdcd9 August 13, 2021 05:52

jbarz1 dismissed ahsan-z-khan’s stale review via 1abdcd9 August 13, 2021 05:52

fix typo

02ad179

fix typo

3964980

saimidu approved these changes Aug 13, 2021

View reviewed changes

shreyapandit approved these changes Aug 13, 2021

View reviewed changes

ahsan-z-khan approved these changes Aug 13, 2021

View reviewed changes

ahsan-z-khan merged commit c62ce81 into aws:master Aug 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature: add pytorch 1.5.1 eia configuration #2441

feature: add pytorch 1.5.1 eia configuration #2441

jbarz1 commented Jun 11, 2021

sagemaker-bot commented Jun 11, 2021

sagemaker-bot commented Jun 11, 2021

sagemaker-bot commented Jun 11, 2021

sagemaker-bot commented Jun 11, 2021

sagemaker-bot commented Jun 11, 2021

jbarz1 commented Jun 11, 2021

ahsan-z-khan commented Aug 10, 2021

sagemaker-bot commented Aug 10, 2021

sagemaker-bot commented Aug 10, 2021

sagemaker-bot commented Aug 10, 2021

sagemaker-bot commented Aug 10, 2021

sagemaker-bot commented Aug 10, 2021

sagemaker-bot commented Aug 12, 2021

jbarz1 commented Aug 12, 2021

ahsan-z-khan commented Aug 12, 2021

saimidu Aug 12, 2021

shreyapandit Aug 13, 2021 •

edited

Loading

saimidu Aug 12, 2021

jbarz1 Aug 13, 2021

saimidu Aug 13, 2021

sagemaker-bot commented Aug 13, 2021

sagemaker-bot commented Aug 13, 2021

		@@ -26,16 +25,22 @@
		"eu-central-1": "763104351884",
		"eu-north-1": "763104351884",

feature: add pytorch 1.5.1 eia configuration #2441

feature: add pytorch 1.5.1 eia configuration #2441

Conversation

jbarz1 commented Jun 11, 2021

Merge Checklist

General

Tests

sagemaker-bot commented Jun 11, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jun 11, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jun 11, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jun 11, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jun 11, 2021

AWS CodeBuild CI Report

jbarz1 commented Jun 11, 2021

ahsan-z-khan commented Aug 10, 2021

sagemaker-bot commented Aug 10, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 10, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 10, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 10, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 10, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 12, 2021

AWS CodeBuild CI Report

jbarz1 commented Aug 12, 2021

ahsan-z-khan commented Aug 12, 2021

saimidu Aug 12, 2021

Choose a reason for hiding this comment

shreyapandit Aug 13, 2021 • edited Loading

Choose a reason for hiding this comment

saimidu Aug 12, 2021

Choose a reason for hiding this comment

jbarz1 Aug 13, 2021

Choose a reason for hiding this comment

saimidu Aug 13, 2021

Choose a reason for hiding this comment

sagemaker-bot commented Aug 13, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Aug 13, 2021

AWS CodeBuild CI Report

shreyapandit Aug 13, 2021 •

edited

Loading