Skip to content

Fix expand-role to use boto_session field #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

winstonaws
Copy link
Contributor

@winstonaws winstonaws commented Jun 14, 2018

Description of changes:

sagemaker.Session's expand_role method needs to use its boto_session field to call IAM, so it can use the configuration passed in by the user.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@winstonaws winstonaws requested a review from iquintero June 14, 2018 19:47
@codecov-io
Copy link

Codecov Report

Merging #232 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files          45       45           
  Lines        3166     3166           
=======================================
  Hits         2896     2896           
  Misses        270      270
Impacted Files Coverage Δ
src/sagemaker/session.py 86.7% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72121b...85db71d. Read the comment docs.

@winstonaws winstonaws merged commit fb91511 into aws:master Jun 14, 2018
@winstonaws winstonaws deleted the expand_role_session_fix branch June 14, 2018 22:27
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Updated: local mode notebooks based on comments from first PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants