Skip to content

Add integ tests for tuning jobs #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 8, 2018
Merged

Add integ tests for tuning jobs #220

merged 4 commits into from
Jun 8, 2018

Conversation

ChoiByungWook
Copy link
Contributor

@ChoiByungWook ChoiByungWook commented Jun 8, 2018

Issue #, if available:

Description of changes:
Add integration tests for tuning jobs.

Add ability to attach for LDA jobs.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ChoiByungWook ChoiByungWook requested a review from laurenyu June 8, 2018 00:41
laurenyu
laurenyu previously approved these changes Jun 8, 2018
@codecov-io
Copy link

codecov-io commented Jun 8, 2018

Codecov Report

Merging #220 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   91.49%   91.46%   -0.03%     
==========================================
  Files          45       45              
  Lines        3163     3165       +2     
==========================================
+ Hits         2894     2895       +1     
- Misses        269      270       +1
Impacted Files Coverage Δ
src/sagemaker/amazon/lda.py 97.5% <50%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc5ccc...dd816b1. Read the comment docs.

@ChoiByungWook ChoiByungWook merged commit 3fb5516 into aws:master Jun 8, 2018
@ChoiByungWook ChoiByungWook deleted the tuning_integ_tests branch June 8, 2018 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants