Skip to content

infra: move package preparation and publishing to the deploy step #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2021
Merged

infra: move package preparation and publishing to the deploy step #2142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion buildspec-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,16 @@ version: 0.2
phases:
build:
commands:
- PACKAGE_FILE="$CODEBUILD_SRC_DIR_ARTIFACT_1/sagemaker-*.tar.gz"
# prepare the release (update versions, changelog etc.)
- git-release --prepare

# generate the distribution package
- python3 setup.py sdist

# publish the release to github
- git-release --publish

- PACKAGE_FILE="dist/sagemaker-*.tar.gz"
- PYPI_USER=$(aws secretsmanager get-secret-value --secret-id /codebuild/pypi/user --query SecretString --output text)
- PYPI_PASSWORD=$(aws secretsmanager get-secret-value --secret-id /codebuild/pypi/password --query SecretString --output text)
- GPG_PRIVATE_KEY=$(aws secretsmanager get-secret-value --secret-id /codebuild/gpg/private_key --query SecretString --output text)
Expand Down
15 changes: 0 additions & 15 deletions buildspec-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ version: 0.2
phases:
build:
commands:
# prepare the release (update versions, changelog etc.)
- git-release --prepare

# run linters
- tox -e flake8,pylint

Expand All @@ -22,15 +19,3 @@ phases:

# run a subset of the integration tests
- IGNORE_COVERAGE=- tox -e py36 -- tests/integ -m canary_quick -n 64 --boxed --reruns 2

# generate the distribution package
- python3 setup.py sdist

# publish the release to github
- git-release --publish

artifacts:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this being used as a form of archiving?

Copy link
Contributor Author

@ajaykarpur ajaykarpur Feb 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it was just stored as an artifact for the purpose of passing it to the next pipeline stage.

files:
- dist/sagemaker-*.tar.gz
name: ARTIFACT_1
discard-paths: yes