Skip to content

Fix Local Mode for non Framework containers. #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

iquintero
Copy link
Contributor

Don't assume that sagemaker_submit_directory is present in the
hyperparameters.

Issue #, if available:

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • [x ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [x ] I have updated the changelog with a description of my changes (if appropriate)
  • [x ] I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Don't assume that sagemaker_submit_directory is present in the
hyperparameters.
@iquintero iquintero requested a review from nadiaya June 5, 2018 18:10
Copy link
Contributor

@nadiaya nadiaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an integ (or unit).
Talked offline - Nacho is adding it.

@codecov-io
Copy link

Codecov Report

Merging #213 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   91.55%   91.49%   -0.07%     
==========================================
  Files          45       45              
  Lines        3162     3163       +1     
==========================================
- Hits         2895     2894       -1     
- Misses        267      269       +2
Impacted Files Coverage Δ
src/sagemaker/local/image.py 85.48% <100%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab57f2d...c4422cc. Read the comment docs.

@iquintero iquintero merged commit d0b7384 into aws:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants