Add tags for training jobs #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenyu
requested review from
ChoiByungWook and
iquintero
and removed request for
ChoiByungWook
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 90.93% 90.76% -0.18%
==========================================
Files 42 42
Lines 2714 2717 +3
==========================================
- Hits 2468 2466 -2
- Misses 246 251 +5
Continue to review full report at Codecov.
|
This should increase code coverage by testing if the optional training parameters are set by the user.
iquintero
previously approved these changes
Jun 1, 2018
ChoiByungWook
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This has been supported in SageMaker but not in the Python SDK - this change allows users to add tags to training jobs.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.