change: add type annotations for Lineage #2079

stisac · 2021-01-07T22:50:37Z

Issue #, if available: https://sim.amazon.com/issues/AML-96242

Description of changes: Added Type Annotations for .py files under lineage directory

Testing done:

tox -e py39 -- tests/unit/sagemaker/lineage

collected 45 items

tests/unit/sagemaker/lineage/test_action.py ........... [ 24%]
tests/unit/sagemaker/lineage/test_artifact.py ............ [ 51%]
tests/unit/sagemaker/lineage/test_association.py ....... [ 66%]
tests/unit/sagemaker/lineage/test_context.py ........... [ 91%]
tests/unit/sagemaker/lineage/test_dataset_artifact.py . [ 93%]
tests/unit/sagemaker/lineage/test_endpoint_context.py . [ 95%]
tests/unit/sagemaker/lineage/test_model_artifact.py . [ 97%]
tests/unit/sagemaker/lineage/test_visualizer.py . [100%]

-> tox -e py39 -- tests/integ/sagemaker/lineage

collected 28 items

tests/integ/sagemaker/lineage/test_action.py ....... [ 25%]
tests/integ/sagemaker/lineage/test_artifact.py ........ [ 53%]
tests/integ/sagemaker/lineage/test_association.py sss [ 64%]
tests/integ/sagemaker/lineage/test_context.py ....... [ 89%]
tests/integ/sagemaker/lineage/test_dataset_artifact.py . [ 92%]
tests/integ/sagemaker/lineage/test_endpoint_context.py . [ 96%]
tests/integ/sagemaker/lineage/test_model_artifact.py . [100%]

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2021-01-07T22:53:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 57d9ba4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-07T22:53:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 57d9ba4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-07T22:53:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 57d9ba4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-07T23:34:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 57d9ba4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T00:06:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3b9ec1b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T00:06:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3b9ec1b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T00:06:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3b9ec1b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T00:33:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e1bc680
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T00:34:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e1bc680
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

danabens · 2021-01-08T00:39:38Z

why are unit tests failing?

stisac · 2021-01-08T00:44:54Z

why are unit tests failing?

The unit tests when run in local are passing, not sure what's happening here. Looking into it

sagemaker-bot · 2021-01-08T00:47:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3b9ec1b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

stisac · 2021-01-08T00:59:52Z

why are unit tests failing?

The unit tests when run in local are passing, not sure what's happening here. Looking into it

Just observed that the integ tests for association are getting skipped while running in local

sagemaker-bot · 2021-01-08T01:06:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e1bc680
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T01:16:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 82b7ce5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T01:16:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 82b7ce5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T01:18:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 82b7ce5
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T01:19:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e1bc680
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T01:34:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f412464
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T01:35:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f412464
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T01:35:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f412464
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T01:54:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 82b7ce5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-01-08T02:11:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f412464
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

icywang86rui · 2021-01-08T18:05:30Z

Please fix the build errors.

sagemaker-bot · 2021-01-08T18:07:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 682e2db
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T01:31:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9a49903
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T02:07:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9a49903
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T02:08:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9a49903
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T02:12:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9a49903
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T02:16:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9a49903
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

danabens · 2021-03-05T15:20:18Z

src/sagemaker/lineage/context.py

@@ -65,15 +69,15 @@ class Context(_base_types.Record):
    ]
    _boto_delete_members = ["context_name"]

-    def save(self):
+    def save(self) -> "Context":


why are some of these return types in quotes?

Added __annotations__ from future import and resolved issue. Removed quotes to get pass the issue of
NameError: name 'Context' is not defined

Looks like the above is possible from py37 onwards and thus reverting to use quotes

sagemaker-bot · 2021-03-05T18:47:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a27df8d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T19:17:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a27df8d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T19:25:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a27df8d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

danabens · 2021-03-05T19:25:56Z

fix checks and I'll approve

sagemaker-bot · 2021-03-05T19:29:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a27df8d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T19:30:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a27df8d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T19:41:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e363696
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T20:05:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e363696
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T20:08:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e363696
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T20:13:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: e363696
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-05T20:14:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e363696
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ChoiByungWook · 2021-03-05T20:15:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr

Commit ID: e363696

Result: FAILED

Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Ran into instances not being available. Rerunning CI.

sagemaker-bot · 2021-03-05T20:40:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: e363696
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

stisac requested review from danabens and yzhu0 January 7, 2021 22:50

stisac force-pushed the iss96242 branch from 3b9ec1b to e1bc680 Compare January 8, 2021 00:30

stisac force-pushed the iss96242 branch from e1bc680 to 82b7ce5 Compare January 8, 2021 01:14

stisac force-pushed the iss96242 branch from 82b7ce5 to f412464 Compare January 8, 2021 01:32

stisac force-pushed the iss96242 branch from a600571 to 9a49903 Compare March 5, 2021 01:15

ChoiByungWook requested review from danabens and ChoiByungWook March 5, 2021 01:33

danabens reviewed Mar 5, 2021

View reviewed changes

stisac force-pushed the iss96242 branch from 9a49903 to a27df8d Compare March 5, 2021 17:45

Add Type annotations for lineage

e363696

stisac force-pushed the iss96242 branch from a27df8d to e363696 Compare March 5, 2021 19:29

danabens self-requested a review March 5, 2021 20:14

ChoiByungWook approved these changes Mar 5, 2021

View reviewed changes

danabens approved these changes Mar 5, 2021

View reviewed changes

ahsan-z-khan approved these changes Mar 5, 2021

View reviewed changes

ChoiByungWook merged commit cc19325 into aws:master Mar 5, 2021

change: add type annotations for Lineage #2079

change: add type annotations for Lineage #2079

Conversation

stisac commented Jan 7, 2021

Merge Checklist

General

Tests

sagemaker-bot commented Jan 7, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 7, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 7, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 7, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

danabens commented Jan 8, 2021

stisac commented Jan 8, 2021

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

stisac commented Jan 8, 2021

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

icywang86rui commented Jan 8, 2021

sagemaker-bot commented Jan 8, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Mar 5, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Mar 5, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Mar 5, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Mar 5, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Mar 5, 2021

AWS CodeBuild CI Report

danabens Mar 5, 2021 • edited Loading

Choose a reason for hiding this comment

stisac Mar 5, 2021

Choose a reason for hiding this comment

stisac Mar 5, 2021

Choose a reason for hiding this comment

sagemaker-bot commented Mar 5, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Mar 5, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Mar 5, 2021

AWS CodeBuild CI Report

danabens commented Mar 5, 2021

sagemaker-bot commented Mar 5, 2021

AWS CodeBuild CI Report

sagemaker-bot commented Mar 5, 2021

AWS CodeBuild CI Report

danabens Mar 5, 2021 •

edited

Loading