Skip to content

feature: warn on 'Stopped' (non-Completed) jobs #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2020
Merged

feature: warn on 'Stopped' (non-Completed) jobs #2000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b055a67
feature: warn on 'Stopped' (non-Completed) jobs
athewsey Nov 24, 2020
bc6dddd
Merge branch 'master' into feat/badstop
ajaykarpur Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/sagemaker/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3121,7 +3121,13 @@ def _check_job_status(self, job, desc, status_key_name):
# If the status is capital case, then convert it to Camel case
status = _STATUS_CODE_TABLE.get(status, status)

if status not in ("Completed", "Stopped"):
if status == "Stopped":
LOGGER.warning(
"Job ended with status 'Stopped' rather than 'Completed'. "
"This could mean the job timed out or stopped early for some other reason: "
"Consider checking whether it completed as you expect."
)
elif status != "Completed":
reason = desc.get("FailureReason", "(No reason provided)")
job_type = status_key_name.replace("JobStatus", " job")
raise exceptions.UnexpectedStatusException(
Expand Down