Add absolute import checking #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 90.55% 90.66% +0.11%
==========================================
Files 38 38
Lines 2562 2593 +31
==========================================
+ Hits 2320 2351 +31
Misses 242 242
Continue to review full report at Codecov.
|
laurenyu
previously approved these changes
May 10, 2018
| @@ -10,6 +10,8 @@ | |||
| # distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | |||
| # ANY KIND, either express or implied. See the License for the specific | |||
| # language governing permissions and limitations under the License. | |||
| from __future__ import absolute_import | |||
|
|
|||
| import sys | |||
|
|
|||
| import os | |||
There was a problem hiding this comment.
while you're here, want to also group os and sys?
| @@ -1,4 +1,17 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright 2017-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
is there a reason we have 2017-2018 for some and just 2018 for others?
There was a problem hiding this comment.
Not really, I will update all the copyright to the 2017-2018 range.
| @@ -10,3 +10,4 @@ | |||
| # distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | |||
| # ANY KIND, either express or implied. See the License for the specific | |||
| # language governing permissions and limitations under the License. | |||
| from __future__ import absolute_import | |||
There was a problem hiding this comment.
do we need this for files with no code?
iquintero
approved these changes
May 11, 2018
This was referenced May 11, 2018
owen-t
approved these changes
May 11, 2018
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Fix missing word
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#179
#139
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.