change: separate logs() from attach() #1708

chuyang-deng · 2020-07-14T17:26:07Z

Issue #, if available:
#1405

Description of changes:
Disable logs for Estimator.attach() method and add a new logs() method.

Testing done:
Unit test.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

src/sagemaker/estimator.py

sagemaker-bot · 2020-07-14T17:33:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7acdbc4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

metrizable · 2020-07-14T17:35:10Z

src/sagemaker/estimator.py

        return estimator

+    def logs(self):
+        """Display the logs for Estimator's training job. If the output is a tty or a Jupyter


nit pep-0257: single line, continue with detail after blank line

metrizable · 2020-07-14T17:37:12Z

tests/unit/test_estimator.py

+    returned_job_description = RETURNED_JOB_DESCRIPTION.copy()
+    mock_describe_training_job = Mock(
+        name="describe_training_job", return_value=returned_job_description
+    )


is this an opportunity for a fixture?

Yea, there are in total 5 tests using this training job description

sagemaker-bot · 2020-07-14T17:52:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 7acdbc4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-14T17:54:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7acdbc4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-14T18:05:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7acdbc4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T01:15:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c5dafc5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T01:34:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c5dafc5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T01:35:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: c5dafc5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T01:47:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c5dafc5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T16:42:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 17610e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T17:03:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 17610e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T17:14:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 17610e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T17:28:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 17610e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T18:23:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 35c3daa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T18:42:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 35c3daa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T18:55:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 35c3daa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-15T19:14:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 35c3daa
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu · 2020-07-15T21:21:19Z

tests/unit/test_estimator.py

@@ -191,6 +191,16 @@ def sagemaker_session():
    return sms


+@pytest.fixture()


is this per test or per module? (aka are there potential race conditions with the modification of this dictionary in the tests?)

The pytest.fixture by default is run once per test function: https://docs.pytest.org/en/stable/fixture.html#scope-sharing-a-fixture-instance-across-tests-in-a-class-module-or-session

Each test is modifying the RETURNED_JOB_DESCRIPTION.copy() so should not cause race condition.

sagemaker-bot · 2020-07-16T03:25:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 612ae57
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-16T03:46:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 612ae57
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-16T03:50:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 612ae57
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-16T03:58:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 612ae57
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-16T07:05:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 612ae57
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-17T20:31:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3e3d8b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-17T20:50:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3e3d8b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-17T20:55:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-zwei-pr
Commit ID: 3e3d8b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-07-17T21:02:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3e3d8b9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

change: seperate logs() from attach()

7acdbc4

laurenyu changed the title ~~change: seperate logs() from attach()~~ change: separate logs() from attach() Jul 14, 2020

laurenyu reviewed Jul 14, 2020

View reviewed changes

src/sagemaker/estimator.py Show resolved Hide resolved

metrizable reviewed Jul 14, 2020

View reviewed changes

make fixture for training_job_description

c5dafc5

Merge branch 'zwei' into attach-log

17610e0

Merge branch 'zwei' into attach-log

35c3daa

laurenyu reviewed Jul 15, 2020

View reviewed changes

laurenyu approved these changes Jul 15, 2020

View reviewed changes

Merge branch 'zwei' into attach-log

612ae57

Merge branch 'zwei' into attach-log

3e3d8b9

chuyang-deng merged commit bba192a into aws:zwei Jul 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change: separate logs() from attach() #1708

change: separate logs() from attach() #1708

chuyang-deng commented Jul 14, 2020

sagemaker-bot commented Jul 14, 2020

metrizable Jul 14, 2020

metrizable Jul 14, 2020

chuyang-deng Jul 14, 2020

sagemaker-bot commented Jul 14, 2020

sagemaker-bot commented Jul 14, 2020

sagemaker-bot commented Jul 14, 2020

sagemaker-bot commented Jul 15, 2020

sagemaker-bot commented Jul 15, 2020

sagemaker-bot commented Jul 15, 2020

sagemaker-bot commented Jul 15, 2020

sagemaker-bot commented Jul 15, 2020

sagemaker-bot commented Jul 15, 2020

sagemaker-bot commented Jul 15, 2020

sagemaker-bot commented Jul 15, 2020

sagemaker-bot commented Jul 15, 2020

sagemaker-bot commented Jul 15, 2020

sagemaker-bot commented Jul 15, 2020

sagemaker-bot commented Jul 15, 2020

laurenyu Jul 15, 2020

chuyang-deng Jul 15, 2020

sagemaker-bot commented Jul 16, 2020

sagemaker-bot commented Jul 16, 2020

sagemaker-bot commented Jul 16, 2020

sagemaker-bot commented Jul 16, 2020

sagemaker-bot commented Jul 16, 2020

sagemaker-bot commented Jul 17, 2020

sagemaker-bot commented Jul 17, 2020

sagemaker-bot commented Jul 17, 2020

sagemaker-bot commented Jul 17, 2020

		@@ -191,6 +191,16 @@ def sagemaker_session():
		return sms


		@pytest.fixture()

change: separate logs() from attach() #1708

change: separate logs() from attach() #1708

Conversation

chuyang-deng commented Jul 14, 2020

Merge Checklist

General

Tests

sagemaker-bot commented Jul 14, 2020

AWS CodeBuild CI Report

metrizable Jul 14, 2020

Choose a reason for hiding this comment

metrizable Jul 14, 2020

Choose a reason for hiding this comment

chuyang-deng Jul 14, 2020

Choose a reason for hiding this comment

sagemaker-bot commented Jul 14, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 14, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 14, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 15, 2020

AWS CodeBuild CI Report

laurenyu Jul 15, 2020

Choose a reason for hiding this comment

chuyang-deng Jul 15, 2020

Choose a reason for hiding this comment

sagemaker-bot commented Jul 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 16, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 17, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 17, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 17, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jul 17, 2020

AWS CodeBuild CI Report