feature: handle separate training/inference images and EI in image_uris.retrieve #1707
Conversation
…is.retrieve This change also introduces configuration for TensorFlow image URIs
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| import os | ||
|
|
||
| from sagemaker import utils | ||
|
|
||
| logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
I don't think I had a vision for this - just went with whatever looked reasonable after doing a grep -r "logger =" src 😅
src/sagemaker/image_uris.py
Outdated
| """Creates a tag for the image URI.""" | ||
| tag = "{}-{}".format(version, processor) | ||
| if py_version: | ||
| tag += "-{}".format(py_version) |
There was a problem hiding this comment.
re: this, unify the way you do this?
| def tf_version(request): | ||
| return request.param | ||
| @pytest.fixture(scope="module") | ||
| def tf_version(tensorflow_training_version): |
There was a problem hiding this comment.
Will there be a tensorflow_serving_version?
There was a problem hiding this comment.
this PR creates tensorflow_training_version, tensorflow_inference_version, and tensorflow_ei_version. I'll fix all the fixture usage in the tests in a separate PR - I was worried that this PR had too many changes already 😂
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #, if available:
#1464
Description of changes:
This change also introduces configuration for TensorFlow image URIs. Because it's already a pretty sizeable change, I chose not to modify the tests too much - I'll fix the TF fixtures in a future PR.
Testing done:
tox --parallel all tests/unitMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.