infra: refactor matching logic in v2 migration tool #1654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
laurenyu
commented
Jun 30, 2020
| modifiers.framework_version.FrameworkVersionEnforcer(), | ||
| modifiers.tf_legacy_mode.TensorFlowLegacyModeConstructorUpgrader(), | ||
| modifiers.tf_legacy_mode.TensorBoardParameterRemover(), | ||
| modifiers.deprecated_params.TensorFlowScriptModeParameterRemover(), | ||
| modifiers.tfs.TensorFlowServingConstructorRenamer(), | ||
| modifiers.predictors.PredictorConstructorRefactor(), |
There was a problem hiding this comment.
this change is because the TFS constructor change for Predictor --> TensorFlowPredictor is covered, so we want to prevent false positives from RealTimePredictor --> Predictor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
metrizable
approved these changes
Jun 30, 2020
| modifiers.framework_version.FrameworkVersionEnforcer(), | ||
| modifiers.tf_legacy_mode.TensorFlowLegacyModeConstructorUpgrader(), | ||
| modifiers.tf_legacy_mode.TensorBoardParameterRemover(), | ||
| modifiers.deprecated_params.TensorFlowScriptModeParameterRemover(), | ||
| modifiers.tfs.TensorFlowServingConstructorRenamer(), | ||
| modifiers.predictors.PredictorConstructorRefactor(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1653 (comment)
Description of changes:
I was about to add another modifier and realized I might as well get this refactoring done so I don't re-implement this logic again.
Testing done:
unit tests, linters
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.