Skip to content

change: make v2 migration script add version args when needed #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

change: make v2 migration script add version args when needed #1601

merged 1 commit into from
Jun 17, 2020

Conversation

metrizable
Copy link
Contributor

Issue #, if available: #1465

Description of changes:

changes include:

  • transmogrify framework and model constructors to include framework_version and py_version, as appropriate
  • testing

Testing done:

unit:

% tox --parallel 3 tests/unit
✔ OK black-format in 7.752 seconds
✔ OK flake8 in 21.401 seconds
✔ OK twine in 14.38 seconds
✔ OK pylint in 34.061 seconds
✔ OK doc8 in 19.642 seconds
✔ OK py36 in 52.532 seconds
✔ OK sphinx in 1 minute, 36.107 seconds
✔ OK py37 in 50.303 seconds
✔ OK py38 in 45.694 seconds
✔ OK py27 in 2 minutes, 10.535 seconds

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to any/all clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 0adb1c8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 0adb1c8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-zwei-pr
  • Commit ID: 0adb1c8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 0adb1c8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

laurenyu
laurenyu previously approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I left a handful of small (mostly optional) comments, so feel free to address in a separate PR if needed

@metrizable metrizable force-pushed the populate-version-args branch from 0adb1c8 to 1d409b3 Compare June 17, 2020 17:18
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-zwei-pr
  • Commit ID: 1d409b3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 1d409b3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 1d409b3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 1d409b3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 1d409b3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 1d409b3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 1d409b3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@metrizable metrizable merged commit e4bf952 into aws:zwei Jun 17, 2020
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 1d409b3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@metrizable metrizable deleted the populate-version-args branch June 17, 2020 22:10
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
@chad119 @nargokul @pintaoz-aws
Fix: remove the special condition and fix the unit test (#1601)
2cc4495 
* Fix: move the functionality from latest_container_image to retrieve

* address some comments from Gokul and add unit test

* remove extra functions and rewrite the test

* fix unit test

* fix for other unit test

* unit test fix

* fix unit test: add one more condition

* more unit tests fix

* remove redundant files

* remove the special condition and fix the unit test

---------

Co-authored-by: Chad Chiang <[email protected]>
Co-authored-by: Gokul Anantha Narayanan <[email protected]>
pintaoz-aws pushed a commit that referenced this pull request Dec 4, 2024
@chad119 @nargokul @pintaoz-aws
Fix: remove the special condition and fix the unit test (#1601)
87c2563 
* Fix: move the functionality from latest_container_image to retrieve

* address some comments from Gokul and add unit test

* remove extra functions and rewrite the test

* fix unit test

* fix for other unit test

* unit test fix

* fix unit test: add one more condition

* more unit tests fix

* remove redundant files

* remove the special condition and fix the unit test

---------

Co-authored-by: Chad Chiang <[email protected]>
Co-authored-by: Gokul Anantha Narayanan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenyu laurenyu laurenyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metrizable @sagemaker-bot @laurenyu