Skip to content

Convert file to ascii from utf-8 to avoind compile (and install failu… #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 11, 2017

Conversation

mfranklin1
Copy link
Contributor

…re) on windows

pip install sagemaker
Collecting sagemaker
Using cached sagemaker-1.0.0.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\martinfr\AppData\Local\Temp\pip-build-w9iiq2qf\sagemaker\setup.py", line 18, in
long_description=read('README.rst'),
File "C:\Users\martinfr\AppData\Local\Temp\pip-build-w9iiq2qf\sagemaker\setup.py", line 9, in read
return open(os.path.join(os.path.dirname(file), fname)).read()
File "C:\Tools\Anaconda3\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 2576: character maps to

Sagemaker now builds and installs on windows 10

…re) on windows

pip install sagemaker
Collecting sagemaker
  Using cached sagemaker-1.0.0.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\martinfr\AppData\Local\Temp\pip-build-w9iiq2qf\sagemaker\setup.py", line 18, in <module>
        long_description=read('README.rst'),
      File "C:\Users\martinfr\AppData\Local\Temp\pip-build-w9iiq2qf\sagemaker\setup.py", line 9, in read
        return open(os.path.join(os.path.dirname(__file__), fname)).read()
      File "C:\Tools\Anaconda3\lib\encodings\cp1252.py", line 23, in decode
        return codecs.charmap_decode(input,self.errors,decoding_table)[0]
    UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 2576: character maps to <undefined>

Sagemaker now builds and installs on windows 10
@laurenyu
Copy link
Contributor

laurenyu commented Dec 8, 2017

Hi, thanks for submitting this!

The build is successful for Python 2.7, but for Python 3.5, it produces the following error:

ERROR: actionid: tox

msg: packaging

cmdargs: ['/home/travis/virtualenv/python3.5.3/bin/python', local('/home/travis/build/aws/sagemaker-python-sdk/setup.py'), 'sdist', '--formats=zip', '--dist-dir', local('/home/travis/build/aws/sagemaker-python-sdk/.tox/dist')]

Traceback (most recent call last):

  File "setup.py", line 18, in <module>

    long_description=read('README.rst'),

  File "setup.py", line 9, in read

    return open(os.path.join(os.path.dirname(__file__), fname)).read()

  File "/home/travis/virtualenv/python3.5.3/lib/python3.5/codecs.py", line 321, in decode

    (result, consumed) = self._buffer_decode(data, self.errors, final)

UnicodeDecodeError: 'utf-8' codec can't decode byte 0x93 in position 2568: invalid start byte

ERROR: FAIL could not package project - v = InvocationError('/home/travis/virtualenv/python3.5.3/bin/python /home/travis/build/aws/sagemaker-python-sdk/setup.py sdist --formats=zip --dist-dir /home/travis/build/aws/sagemaker-python-sdk/.tox/dist (see /home/travis/build/aws/sagemaker-python-sdk/.tox/log/tox-0.log)', 1)

It looks like it's having issues with the smart quotes. Would you mind replacing them with normal quotes?

@mfranklin1
Copy link
Contributor Author

mfranklin1 commented Dec 9, 2017 via email

@laurenyu
Copy link
Contributor

laurenyu commented Dec 9, 2017

Hi Martin,

For me, the character at 2568 is the double quote before "doc" on line 81 - it looks like a smart quote given that the lines in the quote are angled rather than vertical, i.e. instead of ". I realize you didn't introduce the smart quotes in the file, but it seems that the switch to UTF-8 is causing this to surface. Can you try replacing the quotes?

Edit: Just noticed you posted a commit as I was typing this.

Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching all of those!

@laurenyu laurenyu merged commit 4a30f56 into aws:master Dec 11, 2017
laurenyu added a commit to laurenyu/sagemaker-python-sdk that referenced this pull request May 31, 2018
… method (aws#15)

* Refactor EstimatorBase and Framework to have a prepare_for_training() method

* Specify argument directly instead of using **kwargs
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
athewsey pushed a commit to athewsey/sagemaker-python-sdk that referenced this pull request May 21, 2021
Integration test of requirements.txt + script bundle functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants