change: add super() call in Local Mode DataSource subclasses #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to address Pylint's W0231 (super-init-not-called)
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
chuyang-deng
approved these changes
Apr 27, 2020
benieric
pushed a commit
to benieric/sagemaker-python-sdk
that referenced
this pull request
Jun 4, 2024
…L changes. (aws#1443) * Add XGB Benchmarker unit test and data files. Also minor changes to traffic pattern config and ungated model id. * Fix comment. * Add function to download or get s3 location of concurrency-metric CSV from s3. * bug fix: handle case in benchmark_job.wait() when logStream hasn't been created yet. * Update LOGISTIC_GROWTH with 256 user step size, and max users of 2048. Modify default imports. * Add Benchmarker integ test for JumpStart Model + public tokenizer. * JS model + private tokenizer + streaming integ test. HF model + public tokenizer + methodology integ test. Use tempfile lib for reading benchmarking results CSV instead of downloading and removing local CSV. * Add documentation for Benchmarker-related classes. * Remove trailing whitespace. --------- Co-authored-by: Joseph Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This is to address Pylint's W0231 (super-init-not-called)
Testing done:
tox -e pylintMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.