Fix local mode not using the right s3 bucket. #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local Mode should honor the inputs instead of wrongly assuming that everyone is using the default bucket.
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=========================================
+ Coverage 90.27% 90.48% +0.2%
=========================================
Files 36 36
Lines 2438 2438
=========================================
+ Hits 2201 2206 +5
+ Misses 237 232 -5
Continue to review full report at Codecov.
|
winstonaws
suggested changes
Apr 13, 2018
tests/unit/test_image.py
Outdated
| s3_uri = channel['DataSource']['S3DataSource']['S3Uri'] | ||
| if 's3://' in s3_uri: | ||
| bucket, prefix = s3_uri.replace('s3://', '').split('/') | ||
| download_folder_calls.append(call(bucket, prefix, ANY)) |
There was a problem hiding this comment.
Instead of ANY for the channel_dir param - is there a clean way to verify the right argument is being passed?
There was a problem hiding this comment.
Also, I'd recommend just hard coding the expect result rather than using this for loop.
Also added the changelog entry
winstonaws
approved these changes
Apr 13, 2018
|
Amazing! Ya'll know when this will be released in stable? |
Closed
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Updated: README to include video games, TensorFlow BYOM, and basic setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Local Mode should honor the inputs instead of wrongly assuming that
everyone is using the default bucket. Fixes #137 #145
Merge Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.