fix: use format strings intead of os.path.join for Processing paths intended for Unix #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Linux Docker containers
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
chuyang-deng
approved these changes
Apr 22, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
laurenyu
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
7 tasks
7 tasks
7 tasks
benieric
pushed a commit
to benieric/sagemaker-python-sdk
that referenced
this pull request
Jun 4, 2024
) * Add inference benchmarking classes, types, and some function definitions. * Presets and tests, class definitions. * Add Benchmarker tests and fix formatting. * Update classes and presets, add sample payload uploader. * Change BenchmarkJob class to use @DataClass * Fix ValueError message. * Use more list comprehension and pythonic practices. * Add list to BenchmarkJob. Minor fixes to validations. * Update preset values/names, docstrings, use Model.create(). * Format and remove local testing change * Fix outdated IR functions in Session. Implement more class functions and fix bugs caught during e2e testing using XGB model. * Remove test notebook. * Format dataframes, make list functions return df, iron out bugs in sample payload uploader. * Add docstrings. * Set default instance count for Benchmark.deploy() to 1. * Revert traffic pattern durations to 120s (current min supported by IR). * Wire new LLM benchmarking project fields to create_benchmark_job flow. Replace prints with logging. * Fixes for bugs caught during e2e testing. Add processing for detailed metrics DF and fix to_model() bugs. * Change list_benchmark_jobs() to return a list. * Add metric data CSV processing into dict. Minor style/bugfixes. * Implement compare_benchmarks(). Improve dataframe formatting and docstrings. * Fix formatting. --------- Co-authored-by: Joseph Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
When using the Python SDK to construct paths for Docker containers, no matter what the user's platform is, we still expect the Docker container to use Ubuntu (since that's what all the prebuilt SageMaker images use).
This PR is similar to #1391
Testing done:
unit tests - I did some digging to see if I could write a unit test for the Windows case, but it seems like the
os.path.joinimplementation for Unix systems hardcodes "/" (at least in Python 2.7): https://hg.python.org/cpython/file/v2.7.3/Lib/posixpath.pyMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.