-
Notifications
You must be signed in to change notification settings - Fork 1.2k
infra: modify PR template and refactor test #1381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
boto_session = boto3.Session(region_name=DEFAULT_REGION) | ||
s3 = boto3.resource("s3", region_name=DEFAULT_REGION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd rather go with how the other tests do it and not have a fallback at all. That way we explicitly fail if the region is not set instead of potentially masking other errors (e.g. #1308)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you're saying, and I think it's a better idea, but that would likely be best done as a refactor to every situation we currently have, because that's not how we currently do it.
I'd also say we should throw an exception in that case to make sure UTs/ITs catch it:
sagemaker-python-sdk/tests/conftest.py
Line 93 in d9f4dd1
boto3.Session(**boto_config) if boto_config else boto3.Session(region_name=DEFAULT_REGION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a refactor to every situation we currently have
I'd also say we should throw an exception in that case to make sure UTs/ITs catch it
so...these sound like good suggestions...
refactor was addressed in #1407 |
Description of changes: This change modifies the PR template to be slightly clearer and refactors an integ test.
Testing done: UTs/IT.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.