Skip to content

infra: properly fail PR build if has-matching-changes fails #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 25, 2020
Merged

infra: properly fail PR build if has-matching-changes fails #1264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a3f11f
infra: properly fail PR build if has-matching-changes fails
knakad Jan 24, 2020
160b7a3
infra: properly fail PR build if has-matching-changes fails
knakad Jan 24, 2020
c38950b
infra: properly fail PR build if has-matching-changes fails
knakad Jan 24, 2020
4c546bf
infra: properly fail PR build if has-matching-changes fails
knakad Jan 24, 2020
1fded9d
infra: properly fail PR build if has-matching-changes fails
knakad Jan 24, 2020
5eedba8
infra: properly fail PR build if has-matching-changes fails
knakad Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions buildspec-localmodetests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,16 @@ phases:

# local mode tests
- start_time=`date +%s`
- HAS_MATCHING_CHANGES_OUTPUT=$(has-matching-changes "tests/" "src/*.py" "setup.py" "setup.cfg" "buildspec.yml")
- |
if has-matching-changes "tests/" "src/*.py" "setup.py" "setup.cfg" "buildspec.yml"; then
if [ "$HAS_MATCHING_CHANGES" = "Changes Found" ] ; then
tox -e py36 -- tests/integ -m local_mode --durations 50
fi
- ./ci-scripts/displaytime.sh 'py36 local mode' $start_time

- start_time=`date +%s`
- |
if has-matching-changes "tests/" "src/*.py" "setup.py" "setup.cfg" "buildspec.yml"; then
if [ "$HAS_MATCHING_CHANGES" = "Changes Found" ] ; then
tox -e py27 -- tests/integ -m local_mode --durations 50
fi
- ./ci-scripts/displaytime.sh 'py27 local mode' $start_time
3 changes: 2 additions & 1 deletion buildspec-notebooktests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ phases:
# run notebook test
- echo "running notebook test"
- start_time=`date +%s`
- HAS_MATCHING_CHANGES_OUTPUT=$(has-matching-changes "src/*.py" "setup.py" "setup.cfg" "tests/scripts/run-notebook-test.sh")
- |
if has-matching-changes "src/*.py" "setup.py" "setup.cfg" "tests/scripts/run-notebook-test.sh"; then
if [ "$HAS_MATCHING_CHANGES" = "Changes Found" ] ; then
./tests/scripts/run-notebook-test.sh
fi
- ./ci-scripts/displaytime.sh 'notebook test' $start_time
5 changes: 3 additions & 2 deletions buildspec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,16 @@ phases:

# run integration tests
- start_time=`date +%s`
- HAS_MATCHING_CHANGES_OUTPUT=$(has-matching-changes "tests/" "src/*.py" "setup.py" "setup.cfg" "buildspec.yml")
- |
if has-matching-changes "tests/" "src/*.py" "setup.py" "setup.cfg" "buildspec.yml"; then
if [ "$HAS_MATCHING_CHANGES" = "Changes Found" ] ; then
python3 -u ci-scripts/queue_build.py
fi
- ./ci-scripts/displaytime.sh 'build queue' $start_time

- start_time=`date +%s`
- |
if has-matching-changes "tests/" "src/*.py" "setup.py" "setup.cfg" "buildspec.yml"; then
if [ "$HAS_MATCHING_CHANGES" = "Changes Found" ] ; then
tox -e py36 -- tests/integ -m "not local_mode" -n 512 --reruns 3 --reruns-delay 5 --durations 50 --boto-config '{"region_name": "us-east-2"}'
fi
- ./ci-scripts/displaytime.sh 'py36 tests/integ' $start_time
Expand Down