fix: create the correct session for MultiDataModel #1255

chuyang-deng · 2020-01-22T01:14:31Z

Issue #, if available:
MultiDataModel.deploy() uses the non local session when instance_type="local"

Description of changes:
Init LocalSession when instance_type is "local" and MultiDataModel object's sagemaker_session is not LocalSession. The sagemaker_session needs to be initiated because this class provides a method (add_model) that uploads tarball to s3 which requires session.

Testing done:
Integration test with local mode.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2020-01-22T01:21:40Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-22T01:36:39Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-22T01:43:47Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-22T01:47:57Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

dlragha

Changes look good to me, thanks Chuyang!

dlragha · 2020-01-22T21:43:32Z

tests/integ/test_multidatamodel.py

@@ -177,6 +177,69 @@ def test_multi_data_model_deploy_pretrained_models(
        assert "Could not find endpoint" in str(exception.value)


+@pytest.mark.local_mode
+def test_multi_data_model_deploy_pretrained_models_local_mode(
+    container_image, sagemaker_session, cpu_instance_type


minor: remove unused parameter cpu_instance_type?

Good catch! Removed.

sagemaker-bot · 2020-01-22T22:11:58Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-22T22:27:04Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-22T22:40:01Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-22T22:41:02Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-23T17:58:25Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-23T18:14:42Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-23T18:27:45Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-23T18:41:19Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-23T19:16:47Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-23T19:55:05Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-24T01:15:38Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-24T01:27:45Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-24T01:41:27Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-24T01:44:04Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-24T20:27:48Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-25T00:36:56Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-27T19:25:30Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-27T19:25:52Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-27T19:26:18Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-27T19:32:47Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-28T00:15:49Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-28T00:26:02Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-28T00:39:23Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-28T00:43:52Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-28T01:21:59Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-28T01:35:10Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-28T01:41:05Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-28T01:51:13Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2020-01-28T02:45:35Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

fix: create the correct session for MultiDataModel

695b4eb

dlragha reviewed Jan 22, 2020

View reviewed changes

remove unused param in test

5b6ca73

dlragha previously approved these changes Jan 22, 2020

View reviewed changes

fix black-format

0bfed47

chuyang-deng dismissed dlragha’s stale review via 0bfed47 January 23, 2020 17:51

Merge branch 'master' into multidatamodel-local

feef8a2

Merge branch 'master' into multidatamodel-local

fc923fb

Merge branch 'master' into multidatamodel-local

e0da75f

Merge branch 'master' into multidatamodel-local

87fa873

knakad approved these changes Jan 28, 2020

View reviewed changes

chuyang-deng merged commit dbec613 into aws:master Jan 28, 2020

chuyang-deng deleted the multidatamodel-local branch January 28, 2020 05:03

fix: create the correct session for MultiDataModel #1255

fix: create the correct session for MultiDataModel #1255

Conversation

chuyang-deng commented Jan 22, 2020

Merge Checklist

General

Tests

sagemaker-bot commented Jan 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 22, 2020

AWS CodeBuild CI Report

dlragha left a comment

Choose a reason for hiding this comment

dlragha Jan 22, 2020

Choose a reason for hiding this comment

chuyang-deng Jan 22, 2020

Choose a reason for hiding this comment

sagemaker-bot commented Jan 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 22, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 23, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 23, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 23, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 23, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 23, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 23, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 24, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 24, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 24, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 24, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 24, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 25, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 27, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2020

AWS CodeBuild CI Report

sagemaker-bot commented Jan 28, 2020

AWS CodeBuild CI Report