fix: remove docker-compose as a required dependency. #1128
Conversation
…is not installed.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -40,7 +40,6 @@ def read_version(): | |||
| "scipy>=0.19.0", | |||
| "urllib3>=1.21, <1.25", | |||
| "protobuf3-to-dict>=0.1.5", | |||
| "docker-compose>=1.23.0", | |||
| "requests>=2.20.0, <2.21", | |||
There was a problem hiding this comment.
can we also remove this restriction now? 😄 (and maybe also urllib3?)
src/sagemaker/local/image.py
Outdated
| # check if docker-compose is installed | ||
| if shutil.which('docker-compose') is None: | ||
| raise ImportError( | ||
| "'docker-compose' is not installed. Local mode feature will be broken. " + |
There was a problem hiding this comment.
s/Local mode feature will be broken/Local Mode features will not work without docker-compose
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Remove docker-compose as a required dependency, because it has a very restrictive list of dependencies that has been causing numerous issues. Throw an error if it is not installed.
Issue #, if available: #1118
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.