Fix region-handling for integ test sagemaker_session #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iquintero
previously approved these changes
Mar 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 34 34
Lines 2040 2040
=======================================
Hits 1863 1863
Misses 177 177Continue to review full report at Codecov.
|
iquintero
approved these changes
Mar 23, 2018
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a bug where if the region is not configured at all on the box, boto3 will be unable to create clients. This change ensures that the region is configured first.