fix: correct airflow workflow for BYO estimators. #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The airflow workflow for BYO estimators has been broken since a fix made on 09/13/2019. This resolves that issue. Tests to ensure this does not happen again will be added as part of the next airflow commit that prepares training jobs as part of defining training configuration.
laurenyu
approved these changes
Sep 20, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The airflow workflow for BYO estimators has been broken since a fix
made on 09/13/2019. This resolves that issue.
Tests to ensure this does not happen again will be added as part of
the next airflow commit that prepares training jobs as part of
defining training configuration.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.I have added tests that prove my fix is effective or that my feature works (if appropriate)No. Thorough tests that verify each estimator type will be pushed as a separate commit, as I added them as part of a new feature.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.