feature: Add support for PyTorch 1.2 #1025

mvsusp · 2019-09-05T21:42:27Z

Description of changes:

add support for 1.2 PyTorch Containers

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2019-09-05T21:46:52Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-05T21:47:05Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-05T21:57:56Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-05T21:58:07Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-05T22:00:39Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-05T22:01:26Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-05T22:20:05Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…sdk into mvs-pytorch-1.2

sagemaker-bot · 2019-09-06T16:12:25Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-06T16:23:40Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-06T16:25:45Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-06T16:41:22Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-06T17:13:56Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-06T17:16:42Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-06T17:28:02Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-09-06T17:29:43Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-03T17:44:10Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-03T17:51:58Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-03T17:58:13Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-03T18:09:43Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-04T15:18:17Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-04T15:25:50Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-04T15:30:34Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-04T15:43:56Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-04T17:22:45Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-04T17:23:54Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-04T17:29:58Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-04T17:31:25Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-04T17:35:16Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-04T17:36:23Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-04T17:49:45Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-07T19:02:48Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-07T19:31:17Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-15T17:43:41Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-15T17:57:49Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ChoiByungWook

We should update the documentation to point to the new pytorch serving repository and have the new image repos reference the python sdk.

ChoiByungWook · 2019-10-15T18:00:51Z

src/sagemaker/fw_utils.py

+        framework: Name of the frameowork
+        framework_version: framework version
+    """
+    asimov_lowest_pt = [1, 12, 0]


Should gov region be handled here? We can do this in a separate PR.

if the map above is filled out, it should work fine. not sure why an extra method is needed...

lauren pointed this out, but this should be [1,2,0] and not [1,12,0]

sagemaker-bot · 2019-10-15T18:04:58Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-10-15T18:51:58Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ChoiByungWook · 2019-10-15T19:33:01Z

Closing in favor of: #1091

Error was due to not using the repack_model attribute of the model class when defining the container definition.

mvsusp and others added 2 commits September 5, 2019 14:40

Add support for PyTorch 1.2

e216bd7

Merge branch 'master' into mvs-pytorch-1.2

43e7c80

mvsusp added 2 commits September 6, 2019 09:04

fix unit tests

efaccc2

Merge branch 'mvs-pytorch-1.2' of github.com:mvsusp/sagemaker-python-…

e094ed4

…sdk into mvs-pytorch-1.2

Merge branch 'master' into mvs-pytorch-1.2

52a3de2

Merge branch 'master' into mvs-pytorch-1.2

5f0ed7a

Merge branch 'master' into mvs-pytorch-1.2

3fc299e

mvsusp added 2 commits October 4, 2019 10:17

Update estimator.py

1236c6b

Update test_pytorch.py

7cde798

ajaykarpur assigned ajaykarpur and unassigned ajaykarpur Oct 4, 2019

Merge branch 'master' into mvs-pytorch-1.2

74d66c5

ChoiByungWook self-requested a review October 15, 2019 17:39

ChoiByungWook approved these changes Oct 15, 2019

View reviewed changes

ChoiByungWook mentioned this pull request Oct 15, 2019

feature: Add support for PyTorch 1.2.0 #1091

Merged

4 tasks

ChoiByungWook closed this Oct 15, 2019

feature: Add support for PyTorch 1.2 #1025

feature: Add support for PyTorch 1.2 #1025

Conversation

mvsusp commented Sep 5, 2019

Merge Checklist

sagemaker-bot commented Sep 5, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 5, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 5, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 5, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 5, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 5, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 5, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 6, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 6, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 6, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 6, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 6, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 6, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 6, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Sep 6, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 3, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 3, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 3, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 3, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 4, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 4, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 4, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 4, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 4, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 4, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 4, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 4, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 4, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 4, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 4, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 7, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 7, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 15, 2019

AWS CodeBuild CI Report

sagemaker-bot commented Oct 15, 2019

AWS CodeBuild CI Report

ChoiByungWook left a comment

Choose a reason for hiding this comment

ChoiByungWook Oct 15, 2019

Choose a reason for hiding this comment

laurenyu Oct 15, 2019

Choose a reason for hiding this comment

ChoiByungWook Oct 15, 2019