You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the feature you'd like
Right now, repackModel steps write to root of the default bucket. Here's one line from test code that we can verify that:
It would be great if we could expose an output_path and perhaps also a code_location parameters to help us organize our S3 buckets.
How would this feature be used? Please describe.
The feature would be used to help us organize S3 buckets into namespaces/hierachy. For example, right now I organize my prefixes as:
but for future reference, RegisterModel takes kwargs, and you will be able to pass outpout_path as a kwarg to it, and the repack model training job will use it as its OutputDataConfig.S3Outputpath.
Closing this issue, feel free to re-open if you have any other concern.
Describe the feature you'd like
Right now, repackModel steps write to root of the default bucket. Here's one line from test code that we can verify that:
sagemaker-python-sdk/tests/unit/sagemaker/workflow/test_utils.py
Line 143 in f2fd421
It would be great if we could expose an
output_path
and perhaps also acode_location
parameters to help us organize our S3 buckets.How would this feature be used? Please describe.
The feature would be used to help us organize S3 buckets into namespaces/hierachy. For example, right now I organize my prefixes as:
But since repackModel doesn't expose parameters to tune S3 outputs, I also end up some objects in the root, example:
Describe alternatives you've considered
I'd need some guidance to find all the correct places, but I can submit a PR with these changes:
repack_output_path
_RepackModelStep()
calls (L139, L183, L324), handover the parameterrepack_output_path=repack_output_path
._RepackModelStep
, on theSKLearn()
call, addoutput_path=repack_output_path
andcode_location=repack_output_path
.I'd also need help to understand which unit tests would be needed, on
RegisterModel
,EstimatorTransformer
,_RepackModelStep
, or all of them.Thanks for your review!
The text was updated successfully, but these errors were encountered: